Merge pull request #2250 from Expensify/marcaaron-fixPersonalDetailsC…

…rash Initialize current user's personal details when personalDetailsList is non empty and they can't be found
Expensify · Apr 7, 2021 · 3a83195 · 3a83195
2 parents c9f106a + 9c508d8
commit 3a83195
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/libs/actions/PersonalDetails.js b/src/libs/actions/PersonalDetails.js
@@ -110,10 +110,13 @@ function fetch() {
         .then((data) => {
             let myPersonalDetails = {};
 
-            // If personalDetailsList is empty, ensure we set the personal details for the current user
-            const personalDetailsList = _.isEmpty(data.personalDetailsList)
-                ? {[currentUserEmail]: myPersonalDetails}
-                : data.personalDetailsList;
+            // If personalDetailsList does not have the current user ensure we initialize their details with an empty
+            // object at least
+            const personalDetailsList = _.isEmpty(data.personalDetailsList) ? {} : data.personalDetailsList;
+            if (!personalDetailsList[currentUserEmail]) {
+                personalDetailsList[currentUserEmail] = {};
+            }
+
             const allPersonalDetails = formatPersonalDetails(personalDetailsList);
             Onyx.merge(ONYXKEYS.PERSONAL_DETAILS, allPersonalDetails);