Show tasks in LHN #18931

thienlnam · 2023-05-14T22:58:46Z

Details

Fixed Issues

$ #18510
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Create a task
Verify it shows up in the LHN
Add a comment to a task
Verify the subtitle of the task in the LHN updates

Since the back-end changes are not live yet, this will only happen for new tasks you create without logging out or while offline

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-05-15T18:53:26Z

@mananjadhav @techievivek One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/ReportUtils.js

fedirjh · 2023-05-15T23:34:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-15.at.11.30.20.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-05-15.at.11.43.41.PM.mov

Mobile Web - Safari

Screen.Recording.2023-05-15.at.11.21.35.PM.mov

Desktop

Screen.Recording.2023-05-15.at.11.34.34.PM.mov

iOS

Screen.Recording.2023-05-15.at.10.56.51.PM.mov

Android

Screen.Recording.2023-05-15.at.11.41.58.PM.mov

thienlnam · 2023-05-16T02:40:42Z

Ready for a final review cc @techievivek

techievivek

Looks good. @fedirjh Do you wanna do another round of review as there are a few new commits or should I go forward and merge it?

thienlnam · 2023-05-16T16:45:33Z

Going to merge, since the new commits existed before - I just added new changes and then reverted them since they're out of scope for now

OSBotify · 2023-05-16T16:52:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-17T01:08:00Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.15-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-18T06:51:11Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.15-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rushatgabhane · 2023-08-02T17:51:02Z

src/libs/OptionsListUtils.js

@@ -549,6 +550,7 @@ function getOptions(
        forcePolicyNamePreview = false,
        includeOwnedWorkspaceChats = false,
        includeThreads = false,
+        includeTasks = false,


Hey, this PR caused a bug - Task name is not appearing in search page

parasharrajat · 2023-08-17T15:09:38Z

src/libs/SidebarUtils.js

@@ -161,7 +161,8 @@ function getOrderedReportIDs(reportIDFromRoute) {
            return;
        }

-        if (ReportUtils.isTaskReport(report)) {
+        if (ReportUtils.isTaskReport(report) && report.stateNum !== CONST.REPORT.STATE.OPEN && report.statusNum !== CONST.REPORT.STATUS.OPEN) {


Completed Tasks should not be moved to archived reports as a user can still message on the thread. This created #23883 issue.

thienlnam added 2 commits May 14, 2023 01:36

update isThread check and include task reports in LHN

362e25a

Merge branch 'main' into jack-showTasksLHN

ebc31d6

thienlnam self-assigned this May 14, 2023

Merge branch 'main' into jack-showTasksLHN

7361d4d

thienlnam marked this pull request as ready for review May 15, 2023 18:52

thienlnam requested a review from a team as a code owner May 15, 2023 18:52

melvin-bot bot requested review from mananjadhav and techievivek and removed request for a team May 15, 2023 18:53

fedirjh reviewed May 15, 2023

View reviewed changes

src/libs/ReportUtils.js Show resolved Hide resolved

thienlnam added 3 commits May 15, 2023 14:38

Merge branch 'main' into jack-showTasksLHN

66b2840

Merge branch 'main' into jack-showTasksLHN

55ef422

remove from share in and add to search

c56255c

thienlnam added 3 commits May 15, 2023 16:34

prevent crashes

b084181

Merge branch 'main' into jack-showTasksLHN

10bdf44

remove task handling

c48f52e

techievivek reviewed May 16, 2023

View reviewed changes

techievivek approved these changes May 16, 2023

View reviewed changes

thienlnam merged commit fa0ec1b into main May 16, 2023

thienlnam deleted the jack-showTasksLHN branch May 16, 2023 16:45

OSBotify mentioned this pull request May 16, 2023

Deploy Checklist: New Expensify 2023-05-16 #19088

Closed

71 tasks

melvin-bot bot mentioned this pull request May 18, 2023

[$1000] [HOLD for payment 2023-05-25] Show tasks in LHN #18510

Closed

rushatgabhane reviewed Aug 2, 2023

View reviewed changes

rushatgabhane mentioned this pull request Aug 2, 2023

[WAITING ON ASHIM] [$1000] Web - Task name is not searchable #21565

Closed

6 tasks

parasharrajat reviewed Aug 17, 2023

View reviewed changes

parasharrajat mentioned this pull request Aug 17, 2023

[HOLD for payment 2023-08-17] [$1000] Completed task gets re-indexed if edited. #23883

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show tasks in LHN #18931

Show tasks in LHN #18931

thienlnam commented May 14, 2023 •

edited

Loading

melvin-bot bot commented May 15, 2023

fedirjh commented May 15, 2023 •

edited

Loading

thienlnam commented May 16, 2023

techievivek left a comment

thienlnam commented May 16, 2023

OSBotify commented May 16, 2023

OSBotify commented May 17, 2023

OSBotify commented May 18, 2023

rushatgabhane Aug 2, 2023 •

edited

Loading

parasharrajat Aug 17, 2023

Show tasks in LHN #18931

Show tasks in LHN #18931

Conversation

thienlnam commented May 14, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 15, 2023

fedirjh commented May 15, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

thienlnam commented May 16, 2023

techievivek left a comment

Choose a reason for hiding this comment

thienlnam commented May 16, 2023

OSBotify commented May 16, 2023

OSBotify commented May 17, 2023

OSBotify commented May 18, 2023

rushatgabhane Aug 2, 2023 • edited Loading

Choose a reason for hiding this comment

parasharrajat Aug 17, 2023

Choose a reason for hiding this comment

thienlnam commented May 14, 2023 •

edited

Loading

fedirjh commented May 15, 2023 •

edited

Loading

rushatgabhane Aug 2, 2023 •

edited

Loading