[WAITING ON ASHIM] [$1000] Web - Task name is not searchable

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to '+" button,
2. Go to assign task -> add task name -> next
3. Add assignee and share to whom
4. Now a new page with a task details should appear.
5. Go to LHN and search for the particular task.
   Notice that it shows " Results not found".

Expected Result:

The task name should be searchable. It will be easier to search, manage and complete tasks.

Actual Result:

The task name is not searchable causing difficult to locate tasks.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.32-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Untitled_video.2.mov

Recording.5155.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687420359552779

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b3d8ba26f1f06973
• Upwork Job ID: 1676016162463776768
• Last Price Increase: 2023-07-10

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[shawnborton]

Hmm yeah, I would expect anything that shows up in the LHN to be available in Search.

@mountiny @danieldoglas thoughts on this one?

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Task name is not searchable

What is the root cause of that problem?

Our search function has the value includeTasks: false by default, so we couldn't see the task in our search result.

App/src/libs/OptionsListUtils.js

Line 596 in f867c17

includeTasks = false,

What changes do you think we should make in order to solve the problem?

In order to see task in our SearchPage, we can add includeTasks: true in our getSearchOptions function.

Also we need to update our createOptions function here to make our search task result has alternateText:

        if (result.isChatRoom || result.isPolicyExpenseChat) {
            result.alternateText = showChatPreviewLine && !forcePolicyNamePreview && lastMessageText ? lastMessageText : subtitle;
        } else if (result.isMoneyRequestReport) {
            result.alternateText = lastMessageTextFromReport.length > 0 ? lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet');
        } else if (result.isTaskReport) {
// update the alternateText for task report
            result.alternateText = showChatPreviewLine && lastMessageText ? lastMessageTextFromReport :  Localize.translate(preferredLocale, 'report.noActivityYet');
        } else {
            result.alternateText = showChatPreviewLine && lastMessageText ? lastMessageText : LocalePhoneNumber.formatPhoneNumber(personalDetail.login);
        }

And finally update the visibility of the title inside our OptionRow here:

 shouldUseFullTitle={
    this.props.option.isChatRoom || this.props.option.isPolicyExpenseChat || this.props.option.isMoneyRequestReport || 
    this.props.option.isThread || this.props.option.isTaskReport
}

What alternative solutions did you explore? (Optional)

N/A

Result:

Screen.Recording.2023-07-04.at.17.46.20.mov

[jliexpensify]

I can repro this one:

Here's my search:

Let me know if you want this as External @mountiny @danieldoglas

[jliexpensify]

Bump @mountiny and @danieldoglas - are you tackling this one Internally?

[danieldoglas]

Sorry, I think we were both OOO last week!

@jliexpensify This is not an issue related to the search project for now since this is a local search. It's probably more related to the Tasks project, cc @ thienlnam.

[jliexpensify]

No worries! Might tag @thienlnam again (I don't think it worked in your comment Daniel). Jack - is this something you'd want to tackle internally?

[thienlnam]

Let's make this external! We didn't have this problem before since Tasks were not yet showing up in the LHN. But now that they are, let's handle this - agree it should be included!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b3d8ba26f1f06973

[melvin-bot]

Current assignees @JmillsExpensify and @jliexpensify are eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @rushatgabhane Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot]

📣 @rushatgabhane We're missing your Upwork ID to automatically send you an offer for the Reviewer role.
Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @ashimsharma10 We're missing your Upwork ID to automatically send you an offer for the Reporter role.
Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

[hungvu193]

@rushatgabhane @Beamanator #22734 is now ready for review!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Allow user to search for tasks #22734

If no regressions arise, payment will be issued on 2023-07-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify / @jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Hi @rushatgabhane looks like this is due for payment, but the checklist isn't complete. Can you do this please?

Payments:

• @ashimsharma10: $250 // Reporting bonus
• @rushatgabhane: $1000 // C+ (request in New Dot?)
• @hungvu193 : $1000 // Contributor

Upwork job

[jliexpensify]

Bump @rushatgabhane to complete the checklist

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: Show tasks in LHN #18931

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/18931/files#r1282240904

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. Yes

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

   1. Login with any account that has tasks beta.
   2. Go to a chat and assign a task.
   3. Go to search page
   4. Search for that task you assigned
   5. Verify that the task appears in the search result.

[rushatgabhane]

Created a manual request - https://staging.new.expensify.com/r/6576015972951396

[jliexpensify]

Thanks Rushat, I will pay now!

[jliexpensify]

Invited Ashim, paid @hungvu193 and working on the QA list now.

[jliexpensify]

Paid Ashim and job now removed, thanks everyone!

[JmillsExpensify]

Reviewed details for @rushatgabhane. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.