-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect pasted text on copied HTML snippet #13108
Conversation
@danieldoglas @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2022-11-29.at.7.59.00.PM.movMobile Web - ChromeScreen.Recording.2022-11-29.at.8.41.53.PM.movMobile Web - SafariScreen.Recording.2022-11-29.at.8.38.33.PM.movDesktopScreen.Recording.2022-11-29.at.8.00.51.PM.moviOSAndroidScreen.Recording.2022-11-29.at.8.47.42.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well!
Let's merge @danieldoglas. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @danieldoglas in version: 1.2.34-0 🚀
|
🚀 Deployed to production by @luacmartins in version: 1.2.34-1 🚀
|
Details
If you send html snippet as plain text and select the message you just sent, paste to our App textbox or other external editor, the pasted text is NOT the same as the copied text, this PR fix it. PR only affects Web and Desktop.
Since Clipboard API is available only in secure context (https), if you test with your local ip address, you need to enable https first.
App/package.json
Line 19 in fedefd1
Fixed Issues
$ #12271
PROPOSAL: #12271 (comment)
Tests
<a href="takia.html">asd</a>
as plain text(not code or code block) in a chat and sendOffline tests
QA Steps
<a href="takia.html">asd</a>
as plain text(not code or code block) in a chat and sendPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Screenshots/Videos
Web
macOS-Chrome-2022-11-29-052935.mp4
Mobile Web - Chrome
Android-Chrome-2022-11-29-050248.mp4
Mobile Web - Safari
iOS-Safari-2022-11-29-045213.mp4
Desktop
macOS-Desktop-2022-11-29-053236.mp4
iOS
iOS-native-2022-11-29-045613.mp4
Android
Android-native-2022-11-29-051312.mp4