[HOLD for payment 2022-12-08] [$1000] Incorrect pasted text on copied HTML snippet reported by @kerupuksambel

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open staging.new.expensify.com
2. Send this HTML snippet to someone : <a href="takia.html">asd</a>
3. Right click on the message and select the option "Copy to clip board" and paste it to either an external text editor or Expensify textbox

Expected Result:

The pasted text is the same as the copied text

Actual Result:

The pasted text on the external text editor is only asd while the pasted text on the Expensify textbox is [asd](https://staging.new.expensify.com/r/takia.html)

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.2.21-4

Reproducible in staging?: y

Reproducible in production?: y

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Wrong.Snippet.mp4

Recording.812.mp4

Expensify/Expensify Issue URL:

Issue reported by: @kerupuksambel

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666969406840619

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015b92dc642f298147
• Upwork Job ID: 1595305377206034432

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

@Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

Sorry I was ooo, I can't replicate this. Here's what I tried:

1. Copy/paste <a href="takia.html">asd</a> in a chat in staging
2. Click the Copy to Clipboard icon
3. Open TextEdit and paste

Side note, I can see this message in my notifications

[Christinadobrzyn]

@kavimuru can you try to reproduce this again to see what we are doing differently? Feel free to assign this back to me if you can reproduce again.

[kerupuksambel]

@Christinadobrzyn May I try to elaborate? My step to generate the error is :

1. Type <a href="takia.html">asd</a> in a chat in staging
2. Copy the code with highlighting the code and pressing Ctrl+C / Cmd+C
3. Paste it with Ctrl+V / Cmd + V on your text editor.

The bug is remained the same in my side. I also just realized the difference between copying the code from Copy To Clipboard button and using Ctrl/Cmd + C.

[melvin-bot]

@kavimuru Huh... This is 4 days overdue. Who can take care of this?

[Christinadobrzyn]

Hi @kerupuksambel! Thank you so much for the insight - testing this:

Using Copy to Clipboard

1. Type <a href="takia.html">asd</a> in a chat in staging
2. Copy the code by clicking the Copy to Clipboard button
3. Paste it with Ctrl+V / Cmd + V on your text editor.
4. You get <a href="takia.html">asd</a> in text editor

Using Ctrl+C / Cmd+C

1. Type <a href="takia.html">asd</a> in a chat in staging
2. Copy the code with highlighting the code and pressing Ctrl+C / Cmd+C
3. Paste it with Ctrl+V / Cmd + V on your text editor.
4. You get asd in text editor

So the Copy to Clipboard is pasting the <a href="takia.html">asd</a> code into text edit whereas the Ctrl+C / Cmd+C & Ctrl+V / Cmd + V is pasting the result of the code asd. Interesting!

I think this might be similar to this issue #10262 - @parasharrajat would you be able to take a peek at this and see if you think it will be fixed with the changes you're working on in #10262

[parasharrajat]

Investigated this one, it seems like root cause might be same. We are tackling the SetHTML function in the other issue. It is good to know one more bug caused by the same navigator.clipboard.write.

@b1tjoy This might be related to #10262.

[Christinadobrzyn]

Thanks @parasharrajat, I think we should probably hold this until #10262 is resolved to see if that fixes this issue. Let me know if there's a better option.

[parasharrajat]

Good call @Christinadobrzyn.

[b1tjoy]

This one is a regression of PR #11905, ExpensiMark definitely expects encoded html string as parameter.

https://github.com/Expensify/expensify-common/blob/490d695c8ceb54bcff736785b54f06057c32fc9b/lib/ExpensiMark.js#L479

Solution fix both current issue and #11693

Remove the code which encode the selection html.

App/src/libs/SelectionScraper/index.js

Line 136 in 0d653ca

const newHtml = Str.htmlDecode(render(domRepresentation));

-    const newHtml = Str.htmlDecode(render(domRepresentation));
+    const newHtml = render(domRepresentation);

Set decoded html to clipboard as text/plain type.

App/src/components/CopySelectionHelper.js

Line 38 in 0d653ca

Clipboard.setHtml(selection, parser.htmlToText(selection));

-        Clipboard.setHtml(selection, parser.htmlToText(selection));
+        Clipboard.setHtml(selection, Str.htmlDecode(parser.htmlToText(selection)));

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 112 in 0d653ca

Clipboard.setHtml(content, parser.htmlToText(content));

-                         Clipboard.setHtml(content, parser.htmlToText(content));
+                         Clipboard.setHtml(content, Str.htmlDecode(parser.htmlToText(content)));

You may noticed that we found incorrect use of htmlToText() in #10262 (comment), I suggest we fix both #11693 and #12271 in solution of #10262.

Screenshot

macOS-Chrome-2022-11-12-122510.mp4

[JmillsExpensify]

@thesahindia Can you also please assign @b1tjoy to this issue. Thanks!

[b1tjoy]

Please review PR #13108, thanks!

[melvin-bot]

📣 @b1tjoy You have been assigned to this job by @Christinadobrzyn!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Christinadobrzyn]

Thanks @thesahindia! I hired:

• @b1tjoy $1000 for the fix
• @thesahindia $1000 as C+
• @kerupuksambel $250 for reporting

job posting here - https://www.upwork.com/jobs/~015b92dc642f298147

Looks like @b1tjoy is eligible for the 50% merge bonus!

[JmillsExpensify]

2 more days before we exit the 50% bonus period for merged PRs!

[thesahindia]

The PR got merged.

[JmillsExpensify]

Oh whoops, I'm flying through too many issues. Thanks!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix incorrect pasted text on copied HTML snippet #13108

If no regressions arise, payment will be issued on 2022-12-08. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia / @danieldoglas] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia / @danieldoglas] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia / @danieldoglas] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Christinadobrzyn] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here Slack chat about this here

[thesahindia]

The PR that introduced the bug has been identified. Link to the PR:

As mentioned by @b1tjoy, it was a regression from #11905

[thesahindia]

@Christinadobrzyn, this is ready for payment

[Christinadobrzyn]

So sorry for the payment delay, I wasn't sure if there was a regression and I was ooo for a bit. Paid and closed the job.

@b1tjoy $1000 for the fix & $500 bonus (PR in 3 days)
@thesahindia $1000 as C+ & $500 bonus (PR in 3 days)
@kerupuksambel $250 for reporting

[Christinadobrzyn]

@thesahindia @danieldoglas can you please complete the checkboxes here and feel close this GH when you're done!

#12271 (comment)

[thesahindia]

The PR that introduced the bug has been identified. Link to the PR:

#11905

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#11905 (comment)

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://expensify.slack.com/archives/C049HHMV9SM/p1671474832197629

A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here Slack chat about this here

Need help with this one @danieldoglas

[danieldoglas]

Closing this since regression test was created already