Fix: Password form renders when adding bank account #11959

MonilBhavsar · 2022-10-18T10:35:58Z

Details

Looks like when the bank account is deleted, this.state.selectedPlaidAccountID still holds the bank accountID and renders password field. The idea is to check if the bank account still exists before rendering password field or button.

Could also clear the state in componentDidUpdate() (Please see 1st commit) But this sounds better. Let me know if you think the latter is better.

Fixed Issues

$ #11874
PROPOSAL: N/A

Tests

Go to Settings > Payment
If bank account is not added, add one by clicking "Add payment method" > Bank account, else go to step 7
Choose Fidelity bank, enter username and password
Choose Plaid Checking 0000 or Plaid Saving 1111
Enter your password
Click "Continue"
Disable internet connection
Delete VBA
Go back online
Click Add Payment option
Confirm a blank screen with loading indicator only appears. No password field appears.

Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Go to Settings > Payment
If bank account is not added, add one by clicking "Add payment method" > Bank account, else go to step 7
Choose Fidelity bank, enter username and password
Choose Plaid Checking 0000 or Plaid Saving 1111
Enter your password
Click "Continue"
Disable internet connection
Delete VBA
Go back online
Click Add Payment option
Confirm a blank screen with loading indicator only appears. No password field appears.

Verify that no errors appear in the JS console

Screenshots

Web

Screen.Recording.2022-10-19.at.3.33.39.PM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

nkuoch · 2022-10-19T11:00:18Z

src/pages/AddPersonalBankAccountPage.js

        BankAccounts.addPersonalBankAccount(selectedPlaidBankAccount, values.password);
    }

    render() {
        const shouldShowSuccess = lodashGet(this.props, 'personalBankAccount.shouldShowSuccess', false);
+        const isPlaidBankAccountSelected = Boolean(this.state.selectedPlaidAccountID) && !_.isEmpty(this.getSelectedPlaidAccount());


You can probably get rid of Boolean(this.state.selectedPlaidAccountID) && ?

Agree, !_.isEmpty(this.getSelectedPlaidAccount()) will do the job.

Yes, but I think it will be better to short circuit and not call the function at all

thesahindia · 2022-10-19T12:27:47Z

Works well on ~~web, will test other platforms.~~ all platforms.

thesahindia · 2022-10-20T07:05:34Z

Looks good and tests well

C+ reviewed 🎀👀🎀

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

mountiny

There mught be easier solution proposed by @sobitneupane here #12077

What do you think of that @MonilBhavsar (I havent read much into this)

mountiny

What solution do we prefer this one or -> #12077

I feel like the contributor's solution is more straightforward, but the refacotring in this PR is also quite useful.

Thoughts? @MonilBhavsar @nkuoch @Beamanator ?

nkuoch · 2022-10-24T10:30:33Z

You mean the one in #12077? I think I indeed like 12077 better.

mountiny · 2022-10-24T10:41:19Z

@nkuoch yes that one, sorry.

I will move ahead with that and we can keep the refactoring of the method in this one at least, I think that is still useful.

MonilBhavsar · 2022-10-31T06:08:59Z

That looks good to fix this issue. But don't we need the plaidAccountID intialized in the state. I see we're using it at various places in that file. Looking...

nkuoch · 2022-10-31T16:02:55Z

I personally think we can close this PR now that the other one has been merge. We don't need plaidAccountID intialized in the state. I am the one who originally did it, but no need to.

mountiny · 2022-10-31T16:45:28Z

@MonilBhavsar agreeed, lets close this

MonilBhavsar · 2022-11-01T04:47:01Z

Okay, so closing this 👍

MonilBhavsar added 2 commits October 17, 2022 20:55

Clear state if bank account doesn't exist

a227823

Check if the selected bank account still exists

cf9091c

MonilBhavsar self-assigned this Oct 18, 2022

MonilBhavsar changed the title ~~Monil fix add bank account bug~~ Fix: Password form renders when adding bank account Oct 18, 2022

MonilBhavsar marked this pull request as ready for review October 19, 2022 10:48

MonilBhavsar requested a review from a team as a code owner October 19, 2022 10:48

melvin-bot bot requested review from Beamanator and thesahindia and removed request for a team October 19, 2022 10:49

MonilBhavsar requested a review from nkuoch October 19, 2022 10:49

nkuoch approved these changes Oct 19, 2022

View reviewed changes

nkuoch reviewed Oct 19, 2022

View reviewed changes

thesahindia approved these changes Oct 20, 2022

View reviewed changes

thesahindia mentioned this pull request Oct 22, 2022

[HOLD for payment 2022-11-04] [$250] BUG: Enter password field shows on add bank account page while trying to add bank accounts consecutively reported by @adeel0202 #11816

Closed

mountiny reviewed Oct 23, 2022

View reviewed changes

mountiny reviewed Oct 24, 2022

View reviewed changes

MonilBhavsar closed this Nov 1, 2022

thesahindia mentioned this pull request Nov 1, 2022

Web -Payments - Connect Bank account -The user sees a password field when add VBA #11874

Closed

roryabraham deleted the monil-fixAddBankAccountBug branch November 2, 2022 23:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Password form renders when adding bank account #11959

Fix: Password form renders when adding bank account #11959

MonilBhavsar commented Oct 18, 2022 •

edited

Loading

nkuoch Oct 19, 2022

thesahindia Oct 19, 2022

MonilBhavsar Oct 20, 2022

thesahindia commented Oct 19, 2022 •

edited

Loading

thesahindia commented Oct 20, 2022

mountiny left a comment

mountiny left a comment •

edited

Loading

nkuoch commented Oct 24, 2022

mountiny commented Oct 24, 2022

MonilBhavsar commented Oct 31, 2022

nkuoch commented Oct 31, 2022

mountiny commented Oct 31, 2022

MonilBhavsar commented Nov 1, 2022

Fix: Password form renders when adding bank account #11959

Fix: Password form renders when adding bank account #11959

Conversation

MonilBhavsar commented Oct 18, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

nkuoch Oct 19, 2022

Choose a reason for hiding this comment

thesahindia Oct 19, 2022

Choose a reason for hiding this comment

MonilBhavsar Oct 20, 2022

Choose a reason for hiding this comment

thesahindia commented Oct 19, 2022 • edited Loading

thesahindia commented Oct 20, 2022

mountiny left a comment

Choose a reason for hiding this comment

mountiny left a comment • edited Loading

Choose a reason for hiding this comment

nkuoch commented Oct 24, 2022

mountiny commented Oct 24, 2022

MonilBhavsar commented Oct 31, 2022

nkuoch commented Oct 31, 2022

mountiny commented Oct 31, 2022

MonilBhavsar commented Nov 1, 2022

MonilBhavsar commented Oct 18, 2022 •

edited

Loading

thesahindia commented Oct 19, 2022 •

edited

Loading

mountiny left a comment •

edited

Loading