[HOLD for payment 2022-11-04] [$250] BUG: Enter password field shows on add bank account page while trying to add bank accounts consecutively reported by @adeel0202

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Payments
2. Click Add payment method > Bank account
3. Complete the process on Plaid to add a new bank account
4. On Add bank account page, choose an account
5. Enter your password
6. Click save & continue
7. Click Continue
8. Again click Add payment method > Bank account (Notice Enter Expensify password field shows on add bank account page)
9. Again complete the process on Plaid to add another bank account (Notice Enter Expensify password field shows on add bank account page without choosing an account)

Expected Result:

Enter Expensify password field doesn't show until an account is chosen

Actual Result:

Enter Expensify password field shows even when the account is not chosen

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web

Version Number: v1.2.14-0
Reproducible in staging?: y
Reproducible in production?: Could not test in Production
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.687.mp4

Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665648921463259

View all open jobs on GitHub

Screen.Recording.2022-10-13.at.12.54.51.PM.mov

[melvin-bot]

Triggered auto assignment to @sakluger (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[sakluger]

I was able to reproduce this issue, although it's easy to miss, since the password field only shows in the RHN briefly before the Plaid modal pops up. Passing along to engineering.

[melvin-bot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

I see so the problem is that the password page flashes there for a second when doing it second time. I think this issue can be External

[melvin-bot]

Triggered auto assignment to @alexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Current assignee @mountiny is eligible for the External assigner, not assigning anyone new.

[sobitneupane]

Proposal
Reason:

App/src/pages/AddPersonalBankAccountPage.js

Lines 63 to 70 in e38df10

	this.state = {
	selectedPlaidAccountID: this.props.personalBankAccount.plaidAccountID,
	};
	}
	componentDidMount() {
	BankAccounts.clearPersonalBankAccount();
	}

Here, componentDidMount clears personalBankAccount currently being setup. But before that, state selectedPlaidAccountID gets its value from this.props.personalBankAccount.

Solution:

this.state = {
-         selectedPlaidAccountID: this.props.personalBankAccount.plaidAccountID, 
+         selectedPlaidAccountID: '', 
}

This change was recently made in this PR by @nkuoch. Might be an intended change.

cc: @nkuoch

[parasharrajat]

Hmmmmm, my intuition says that we can't just do this change as above. I will take a look at that PR and try to understand the matter.

[nkuoch]

I accept this solution. I'm the one who initially added it in state, but thinking more about it, I agree we should reset it back to empty.

[mountiny]

Great! Thanks for looking into this @nkuoch!

@parasharrajat Can you confirm this proposal before I would assign @sobitneupane? Thank you! 🙇

[parasharrajat]

Let me review it first.

[parasharrajat]

Ok, it seems that we can remove the state initialization. We are clearing the data on componentDidMount thus this does not make sense together. Also, every time we open the connect account page/add a bank account, the process is started again. So the user will select the bank account each time.

@sobitneupane's proposal looks good to me.

cc: @mountiny

🎀 👀 🎀 C+ reviewed

[mountiny]

Thank you @parasharrajat! @sobitneupane Feel free to start the PR!

[melvin-bot]

Triggered auto assignment to @alexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Current assignees @parasharrajat and @sobitneupane are eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @mountiny is eligible for the External assigner, not assigning anyone new.

[thesahindia]

EEP! None of us noticed that we have a dupe issue #11874. We also have a PR for it.

cc: @MonilBhavsar

[mountiny]

Thanks for the ping, gonna look into that

[parasharrajat]

Waiting on the signal from Vit for PR review.

[mountiny]

Signal sent @parasharrajat

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.20-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove unwanted password field in add bank account page #12077
• Remove unwanted password field in add bank account page #12077
• Remove unwanted password field in add bank account page #12077

If no regressions arise, payment will be issued on 2022-11-04. 🎊

[alexpensify]

Based on the hold notice, I'll check tomorrow!

[mallenexpensify]

@sobitneupane @parasharrajat @adeel0202 can you apply for the job here then comment on this issue? https://www.upwork.com/jobs/~01f174bbce556e4071

[sobitneupane]

@mallenexpensify Applied.

[mountiny]

@mallenexpensify will pay this out today.

[mallenexpensify]

All hired, please accept and I'll pay out
https://www.upwork.com/jobs/~01f174bbce556e4071

[mallenexpensify]

Everyone's paid!