Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-02-07] iOS - Back button on import member page loops between import, members and workspace settings #56025

Open
5 of 8 tasks
mitarachim opened this issue Jan 30, 2025 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

mitarachim commented Jan 30, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.92-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.2
App Component: Workspace Settings

Action Performed:

  1. Launch ND or hybrid app.
  2. Go to workspace settings.
  3. Go to Members.
  4. Tap 3-dot menu > Import spreadsheet.
  5. Tap app back button until user is back to Account settings.

Expected Result:

User should be able to return to Account settings using app back button from import page.

Actual Result:

Back button on import page loops between import, members and workspace settings.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6728124_1738205050442.ScreenRecording_01-30-2025_10-40-59_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @anmurali
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Jan 30, 2025
Copy link

melvin-bot bot commented Jan 30, 2025

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 30, 2025

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 30, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 30, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@techievivek
Copy link
Contributor

techievivek commented Jan 30, 2025

@burczu Seems like this might have originated from your PR here #55278

Oops I meant to ping for this #56026 and #56023, you can ignore this GH.

@techievivek
Copy link
Contributor

Looks like it might be coming from here https://github.com/Expensify/App/pull/55478/files? I have pinged Vit in Slack so he can take a look.

@sumo-slonik
Copy link
Contributor

Here is draft PR with a fix for this issue:
#56088

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 Weekly KSv2 labels Jan 30, 2025
@melvin-bot melvin-bot bot changed the title iOS - Back button on import member page loops between import, members and workspace settings [HOLD for payment 2025-02-07] iOS - Back button on import member page loops between import, members and workspace settings Jan 31, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 31, 2025
Copy link

melvin-bot bot commented Jan 31, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 31, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.92-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-07. 🎊

Copy link

melvin-bot bot commented Jan 31, 2025

@techievivek / @mountiny @anmurali @techievivek / @mountiny The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor

@ikevin127 can you please complete the checklist?

The original feature is a big change and to resolve the blocker we reached out to different c+ during to availability- $250 to @ikevin127 for help here

@ikevin127
Copy link
Contributor

ikevin127 commented Jan 31, 2025

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: https://github.com/Expensify/App/pull/55478/files#r1937956026.

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: N/A.

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

  1. Launch ND or HybridApp.
  2. Go to workspace settings.
  3. Go to Members.
  4. Tap 3-dot menu > Import spreadsheet.
  5. Verify that tapping the back button will eventually get the user back to Account settings.

Do we agree 👍 or 👎.

@Beamanator
Copy link
Contributor

Hmm this was also originally reported in #56018, so i think this is NAB anymore

@Beamanator Beamanator removed the DeployBlockerCash This issue or pull request should block deployment label Feb 3, 2025
@Beamanator
Copy link
Contributor

Yeah marking NAB b/c the fix #56088 got to prod

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 3, 2025
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2025-02-07] iOS - Back button on import member page loops between import, members and workspace settings [Due for payment 2025-02-10] [HOLD for payment 2025-02-07] iOS - Back button on import member page loops between import, members and workspace settings Feb 3, 2025
Copy link

melvin-bot bot commented Feb 3, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.93-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-10. 🎊

For reference, here are some details about the assignees on this issue:

  • @ikevin127 requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Feb 3, 2025

@ikevin127 @anmurali @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@ikevin127
Copy link
Contributor

Fix was already deployed to production on 30th of January (reference), BZ Checklist was completed, payment is due on 7th.

@mountiny mountiny changed the title [Due for payment 2025-02-10] [HOLD for payment 2025-02-07] iOS - Back button on import member page loops between import, members and workspace settings [HOLD for payment 2025-02-07] iOS - Back button on import member page loops between import, members and workspace settings Feb 6, 2025
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants