Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Wallet - App returns to previous steps when using device gesture on success page #56026

Open
3 of 8 tasks
mitarachim opened this issue Jan 30, 2025 · 12 comments
Open
3 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.92-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.2
App Component: User Settings

Action Performed:

Precondition:

  • User has assigned themselves a virtual card.
  1. Go to staging.new.expensify.com
  2. Go to Wallet.
  3. Tap on the card.
  4. Tap Report virtual card fraud.
  5. Tap Deactivate card.
  6. Enter magic code.
  7. On success page, use device gesture to go back (swipe to right on iOS).

Expected Result:

App will return to Wallet page.

Actual Result:

App returns to previous deactivating card steps.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6728130_1738205821566.ScreenRecording_01-30-2025_10-53-09_1.mp4

View all open jobs on GitHub

@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Jan 30, 2025
Copy link

melvin-bot bot commented Jan 30, 2025

Triggered auto assignment to @michaelkwardrop (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 30, 2025

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 30, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 30, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@techievivek
Copy link
Contributor

@burczu Seems like this might have originated from your PR here #55278

@burczu
Copy link
Contributor

burczu commented Jan 30, 2025

@techievivek Yes, it seems you are right - this looks like a regression from my PR you've mentioned above. Please assign me - I'll work on fixing it. Thanks

@mountiny
Copy link
Contributor

Happy to take over as I have worked with @burczu on the PR

@burczu
Copy link
Contributor

burczu commented Jan 30, 2025

@mountiny This one is quite tricky actually - I was able to fix it partially, by calling Navigate.closeAndNavigate to open the success page. It closes the Report Virtual Card page before showing the Success page, and this is what we need. Then, when the user slides right using gestures, it lands on the Card Details Page (which is correct). Unfortunately this page is not updated with the new cardID so it shows $0.00 etc. (when user taps Got it! or the Go Back button it is actually navigated to the new Card Details Page with correct cardID).

I think we may need to handle this gesture programmatically using react-native-gesture-handle here. What do you think? Any other ideas?

@burczu
Copy link
Contributor

burczu commented Jan 30, 2025

@mountiny Ok, I have another idea, but it may look kinda' hack'ish - we can remove the Card details page from the stack while we redirecting to the Success page: this way when user uses gestures to close the page, it will land on the Settings -> Wallet page... If they tap on Got it button or on the Go back button it will land on correct Card details page as before. WDYT?

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 30, 2025
@mountiny
Copy link
Contributor

Demoting as the users are not blocked by this action and its mainly about specific ux flow, i dont want to make rushed decisions

@mountiny
Copy link
Contributor

Discussing in the slack thread

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 31, 2025
@burczu
Copy link
Contributor

burczu commented Jan 31, 2025

The PR is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants