[Hold for #30721][$500] IOU - After creating a manual Split Bill, the merchant, date and category are not saved

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.2-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Open New Expensify app
2. Navigate to or create a Workspace Chat
3. In Compose Box, in the action menu, click split bill
4. Complete the Split Bill by filling in any data in the Date, Merchant, Category fields
5. Navigate to the description of the created IOU

Expected Result:

Once a manual split bill has been created, all data entered must be saved.

Actual Result:

After creating a manual Split Bill, the merchant, date and category on the description page are not saved

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6288164_1700720561920.Recording__763.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019c592d650af13034
• Upwork Job ID: 1727653495276339200
• Last Price Increase: 2023-11-30

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019c592d650af13034

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After creating a manual Split Bill, the merchant, date and category on the description page are not saved

What is the root cause of that problem?

1. The back-end is not returning the transaction data, so the data is not displayed
2. For merchant field, when splitting bill here, we're not using the merchant and date field from the IOU to create the transaction. So even if we edit merchant and date in offline mode, they will not be saved.

What changes do you think we should make in order to solve the problem?

1. Fix back-end to return proper transaction data
2. User merchant and date field from the iou when creating transaction when splitting bill (IOU.splitBill, IOU.splitBillAndOpenReport, ...), both to call back-end endpoint and in optimistic data

What alternative solutions did you explore? (Optional)

In 2, if we don't allow date and merchant field in splitting bill, we should hide those fields in the split bill flow

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When creating a manual split bill, the merchant, date, and category are not saved

What is the root cause of that problem?

App/src/pages/iou/steps/MoneyRequestConfirmPage.js

Lines 218 to 225 in 4952c39

	IOU.startSplitBill(
	selectedParticipants,
	props.currentUserPersonalDetails.login,
	props.currentUserPersonalDetails.accountID,
	trimmedComment,
	receipt,
	existingSplitChatReportID,
	);

App/src/pages/iou/steps/MoneyRequestConfirmPage.js

Lines 234 to 243 in 4952c39

	IOU.splitBill(
	selectedParticipants,
	props.currentUserPersonalDetails.login,
	props.currentUserPersonalDetails.accountID,
	props.iou.amount,
	trimmedComment,
	props.iou.currency,
	props.iou.category,
	reportID,
	);

App/src/pages/iou/steps/MoneyRequestConfirmPage.js

Lines 249 to 257 in 4952c39

	IOU.splitBillAndOpenReport(
	selectedParticipants,
	props.currentUserPersonalDetails.login,
	props.currentUserPersonalDetails.accountID,
	props.iou.amount,
	trimmedComment,
	props.iou.currency,
	props.iou.category,
	);

As you can see above, we don't pass these data to the API
This is the root cause

What changes do you think we should make in order to solve the problem?

We need to pass merchant, created, and category data to the SplitBill and SplitBillAndOpenReport APIs

I've verified that passing merchant works fine, but category and created don't work. Backend fix might be needed as well

What alternative solutions did you explore? (Optional)

[fedirjh]

The merchant is being handled in #29691 -> PR (#30721)

[fedirjh]

This seems to require a backend fix to accept the other fields, date, category, and merchant. I also noticed that when the transaction is edited, the new data is reflected in the money request report but inside the IOU preview it does not update

This is the request after the edition :

This is the IOU preview after the edition of the money request :

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[fedirjh]

@dukenv0307 @s-alves10 Will your proposal cover this case as well?

[dukenv0307]

@fedirjh In this case above I think when we change description or other fields which isn't amount it should't updae in split bill because with split bill we have many child transactions.

[melvin-bot]

@fedirjh, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kadiealexander]

@fedirjh any thoughts?

[fedirjh]

@kadiealexander Let's wait for #30721 to get merged.

[fedirjh]

Still on hold for #30721

[fedirjh]

@kadiealexander Issue seems to be fixed with #30721, could not be reproduced. Let's close.

CleanShot.2023-12-28.at.07.23.16.mp4