Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] IOU - In online split bill, merchant "split bill with (participants)id" turned to "request" #31823

Closed
6 tasks done
kbecciv opened this issue Nov 24, 2023 · 9 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Nov 24, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.3.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Tap on a group chat
  3. Tap plus icon---Split bill
  4. Enter an amount
  5. Tap show more and note "request" is shown under "merchant"
  6. Tap split amount
  7. Tap split bill created
  8. Tap show more and note "request" is shown under "merchant"
  9. Navigate to group chat
  10. Turn off mobile data
  11. Perform step 3-step 7
  12. Tap show more and note "split bill with (participants) mail id " is shown under "merchant"section
  13. Turn on mobile data
  14. Note the merchant section

Expected Result:

In both offline and online, the merchant section in split bill detail page must show the same message.

Actual Result:

In offline, under group chat split bill detail page, the merchant section displays "split bill with (participants) mail id " and it is changed to "request" when user turns on mobile data.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6289446_1700827691566.split_changed_to_request.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0124dadd69db8eb9e9
  • Upwork Job ID: 1728036099791814656
  • Last Price Increase: 2023-11-24
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 24, 2023
@melvin-bot melvin-bot bot changed the title IOU - In online split bill, merchant "split bill with (participants)id" turned to "request" [$500] IOU - In online split bill, merchant "split bill with (participants)id" turned to "request" Nov 24, 2023
Copy link

melvin-bot bot commented Nov 24, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0124dadd69db8eb9e9

Copy link

melvin-bot bot commented Nov 24, 2023

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 24, 2023
Copy link

melvin-bot bot commented Nov 24, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Nov 24, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

@dukenv0307
Copy link
Contributor

dukenv0307 commented Nov 24, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

In online split bill, merchant "split bill with (participants)id" turned to "request"

What is the root cause of that problem?

We are adding the merchant for split bill in optimistic data without using iou.merchant

`${Localize.translateLocal('iou.splitBill')} ${Localize.translateLocal('common.with')} ${formattedParticipants} [${DateUtils.getDBTime().slice(0, 10)}]`,

What changes do you think we should make in order to solve the problem?

We should use iou.merchant while creating the transaction for split bill

`${Localize.translateLocal('iou.splitBill')} ${Localize.translateLocal('common.with')} ${formattedParticipants} [${DateUtils.getDBTime().slice(0, 10)}]`,

What alternative solutions did you explore? (Optional)

@chamysoftware
Copy link
Contributor

Could be related to #31781

@aimane-chnaif
Copy link
Contributor

This is already dupe of #30680 or #29691

@melvin-bot melvin-bot bot added the Overdue label Nov 27, 2023
Copy link

melvin-bot bot commented Nov 27, 2023

@ntdiary, @muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@muttmuure
Copy link
Contributor

Closing dupe

@melvin-bot melvin-bot bot removed the Overdue label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants