Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for #29828] [$500] Scan - "Only visible to you" appears after adding Merchant and Amount to the scanning request #31135

Closed
6 tasks done
lanitochka17 opened this issue Nov 9, 2023 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 9, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.97-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Go to workspace chat > + > Request money > Scan
  3. Create a Scan request
  4. While it is still scanning, go to Scan request details page and enter Merchant and Amount manually
  5. Return to expense report

Expected Result:

"Only visible to you" will not show up because Smartscanning is stopped and user has entered manually the required information

Actual Result:

"Only visible to you" shows up after manually entering Merchant and Amount

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6270153_1699544875044.bandicam_2023-11-09_23-44-54-295.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e973dc2edbfc1c22
  • Upwork Job ID: 1722643740994412544
  • Last Price Increase: 2023-11-09
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 9, 2023
@melvin-bot melvin-bot bot changed the title Scan - "Only visible to you" appears after adding Merchant and Amount to the scanning request [$500] Scan - "Only visible to you" appears after adding Merchant and Amount to the scanning request Nov 9, 2023
Copy link

melvin-bot bot commented Nov 9, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01e973dc2edbfc1c22

Copy link

melvin-bot bot commented Nov 9, 2023

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 9, 2023
Copy link

melvin-bot bot commented Nov 9, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Nov 9, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@kbecciv
Copy link

kbecciv commented Nov 9, 2023

Issue should be fixed #29552, but reproducing again on build 1.3.97.0

@paultsimura
Copy link
Contributor

This is a BE issue: the selected proposal in #29552 included a BE fix, which was apparently not implemented. FE-wise that issue was solved correctly.

@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2023
@Victor-Nyagudi
Copy link
Contributor

The reproduction steps here are eerily similar to this other issue.

This comment by @trjExpensify on the issue also mentions interrupting the receipt scan, so we could be looking at a dupe here, or maybe the two issues could be merged into one.

cc: @artus9033 because they're actively working on the other issue.

@sonialiap
Copy link
Contributor

Nice catch, Victor, this looks suuuuper close to #29828.

The PR for that one is already up, just waiting for deploy. I'm hoping it solves the issue in this report but rather than close outright, I'm going to put this one on hold and see if I can reproduce the issue reported here once the PR is live.

@melvin-bot melvin-bot bot removed the Overdue label Nov 13, 2023
@sonialiap sonialiap changed the title [$500] Scan - "Only visible to you" appears after adding Merchant and Amount to the scanning request [HOLD for #29828] [$500] Scan - "Only visible to you" appears after adding Merchant and Amount to the scanning request Nov 13, 2023
@sonialiap sonialiap added Weekly KSv2 and removed Daily KSv2 labels Nov 13, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 21, 2023
@sonialiap
Copy link
Contributor

still on hold for #29828

@melvin-bot melvin-bot bot removed the Overdue label Nov 22, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 1, 2023
@sonialiap
Copy link
Contributor

still on hold for #29828

@melvin-bot melvin-bot bot removed the Overdue label Dec 1, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2023
@sonialiap
Copy link
Contributor

The PR for the hold issue has been merged and looks like #31135 issue can be tested. I will do so later this week

@melvin-bot melvin-bot bot removed the Overdue label Dec 11, 2023
@sonialiap
Copy link
Contributor

I can't reproduce, looks like this is resolved ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants