[SMARTSCAN] [$500] MEDIUM: Scan - Workspace admin sees empty report when employee manually enters Scan request details

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.85-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. [Employee} Create a scan request in the workspace chat
3. [Employee] Manually enter amount and merchant
4. [Admin] Click on the expense preview in the workspace chat with employee when the preview appears

Expected Result:

Workspace admin should be able to view the expense in expense report page

Actual Result:

Workspace admin is unable to view the expense in expense report page. Only the amount is seen in the report page. There is no expense preview that leads to expense details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6240983_1697571472403.20231018_025445.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0100429f58a52793a1
• Upwork Job ID: 1714385920798265344
• Last Price Increase: 2023-11-07

Issue Owner

Current Issue Owner: @cristipaval

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0100429f58a52793a1

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[AmjedNazzal]

Admin can't see it because receipt scan is in progress, a receipt that is still scanning is a whisper so only visible to the user who started it. once the scan completes or fails if the admin refreshes or leave chat and come back they would see the receipt and the changes.

[allroundexperts]

@AmjedNazzal I think it should update without needing to Refresh.

[sakluger]

I agree that it should update. Even though the receipt is still scanning, the user manually entered details, which takes priority over the scanned details.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@sakluger, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sakluger]

Still waiting for proposals.

[melvin-bot]

@sakluger @allroundexperts this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@sakluger, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[sakluger]

I asked for help from our expert contributors: https://expensify.slack.com/archives/C03UK30EA1Z/p1698769699421359

[sakluger]

Callstack was out for a bank holiday yesterday, hoping to hear back today.

[artus9033]

Hi, I'm Artur from Callstack - expert contributor group - and I would like to work on this issue.

[melvin-bot]

📣 @artus9033! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[trjExpensify]

As can be seen in the screenshot below, the request is still a whisper on the employee's side (left; "only visible to you"), but the admin of the workspace (right) sees a request, however the transaction itself is only a whisper thus is not visible to them. To sum up, if I am correct, this is the reason why transaction details are not displayed: because they are not sent over from the backend to them.

Is this the "delay" in updating to not being a whisper?

6. There's a delay in showing the request preview component inside the report to access the request details, it requires a refresh ❌

[artus9033]

aaaah, I see what you're now seeing. The total amount that the workspace owes the employee includes the amount requested for the transaction that is still being scanned, correct?

Correct - that's exactly the thing. It seems like the backend takes the whisper that has been edited manually into account when computing the total (which is probably unwanted behaviour), however does not send over the individual request details.

[artus9033]

As can be seen in the screenshot below, the request is still a whisper on the employee's side (left; "only visible to you"), but the admin of the workspace (right) sees a request, however the transaction itself is only a whisper thus is not visible to them. To sum up, if I am correct, this is the reason why transaction details are not displayed: because they are not sent over from the backend to them.

Is this the "delay" in updating to not being a whisper?

6. There's a delay in showing the request preview component inside the report to access the request details, it requires a refresh ❌

@trjExpensify I guess it was, however currently the problem is not at this step: after the requestor edits the request manually, it never turns into a non-whisper. For instance, the scan request edited manually I created on Nov. 16th is still a whisper today:

But despite that is taken into account to be included in the total value of all money requests in the workspace on the non-requestor's side.

[trjExpensify]

Interesting, yeah. I was giving it a go to repro this and the whisper went away for a request to a workspace (i.e expense report) after editing it twice, but it didn't for a request to another person (i.e iou report). That seems inconsistent with your result above as that's showing the "stuck whisper" on a request to a workspace, so I wonder what the cause of that is?

WueCvRA7Q6.mp4

[cristipaval]

Unassigning myself according to this

[artus9033]

@trjExpensify I checked today and it seems like this is reproducible if you hurry to edit the amount manually before scanning is finished - afterwards, the request remains a whisper forever.

Moreover, I compared the network responses with the newest backend changes. I created a test workspace with 4 requests, one of which remained a whisper forever (if you would like to investigate on your side, it's this one).

The below is a screenshot of network traffic regarding actions (reportActions_1354590800694222) from the requestor's side:

And below is from the other recipient's side:

As can be seen, the missing action is 795...508:

That indeed is a whisper (whisperedTo is a one-element array) and contains IOUTransactionID 503...303, which in turn is:

And this transaction (503...303) is the missing report item (left: requestor, right: other recipient):

However, as visible above, both sides see a valid total sum (all four transactions taken into account), despite the fact that the other recipient "sees" only 3 of them.

This makes me certain that the bug is some kind of race condition or inconsistent handling of state between scanning and manual editing on backend side.

[sonialiap]

Sasha has been back from OOO for a couple weeks but I never unassigned myself, doing that now since we don't need two BZ on this issue

[trjExpensify]

Cool @arthurmfgtab so I think @Gonals & @cristipaval you might need to dig into this then. CC: @mountiny as well. :)

[arthurmfgtab]

@trjExpensify I think you meant to tag @artus9033 😄

[trjExpensify]

Haha, yup. I totally did!

[melvin-bot]

@sakluger, @allroundexperts Huh... This is 4 days overdue. Who can take care of this?

[sakluger]

Switching to weekly since this is Internal but doesn't have an assigned engineer. It's in the "FIRE" section of the milestone, so an engineer should pick it up once they have time.

[Victor-Nyagudi]

This issue also involves interrupting the receipt scanning albeit while splitting a bill in a workspace room. This time, an error is shown after the interruption.

• [$1000] Split - Unexpected error shows up when creating Scan bill split in workspace room #32376

Not sure if it's related but just thought I'd mention it.

[melvin-bot]

This issue has not been updated in over 15 days. @sakluger, @Gonals, @allroundexperts eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[Gonals]

This is fixed