[HOLD for payment 2023-05-29] Renaming chat room does not close RHP

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open a user-created policy room
2. Click on the name in the header
3. Click on Settings
4. Change the room name
5. Click save

Expected Result:

The room name should be updated and the settings modal should close.

Actual result:

The room name updates but the settings modal does not close.

Same behavior with workspace > general settings and notification preference input

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.92-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.107.mp4

Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678551138542469

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b8598111904371a5
• Upwork Job ID: 1642887626659647488
• Last Price Increase: 2023-04-03

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@michaelhaxhiu Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Gonals]

Seems like a quick fix! Taking a look!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01b8598111904371a5

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[Gonals]

Removing C+, as it is a very minor change!

[MelvinBot]

@michaelhaxhiu, @Gonals Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@michaelhaxhiu, @Gonals Huh... This is 4 days overdue. Who can take care of this?

[Gonals]

In review!

[neil-marcellini]

Taking over while Alberto's gone.

[neil-marcellini]

I think I have everything done, but I still need to write some more detailed test steps and then record videos.

[michaelhaxhiu]

Just responding to your comment @neil-marcellini - I think this is an inconsistency and worth fixing, which was touched on in the OG slack thread. I'm glad you are close!

[neil-marcellini]

Ok, now this is actually under review.

[melvin-bot]

@michaelhaxhiu, @Gonals, @neil-marcellini Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[neil-marcellini]

I need to make a small change to the PR based on review feedback. Higher priority issues and PR reviews have come first. Maybe Alberto will be back soon lol

[neil-marcellini]

I'm going to be OOO until Monday fyi. I'll try to find someone to take this over while I'm out.

[neil-marcellini]

Looks like we're all busy and no one picked it up. I'm back. I didn't have time for this today, many PR reviews. Hopefully tomorrow.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.16-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use push to page for report settings #16910

If no regressions arise, payment will be issued on 2023-05-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Gonals / @neil-marcellini] The PR that introduced the bug has been identified. Link to the PR:
  N/A UI refactor
• [@Gonals / @neil-marcellini] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  N/A UI refactor
• [@Gonals / @neil-marcellini] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  N/A UI refactor
• [@Gonals / @neil-marcellini] Determine if we should create a regression test for this bug.
  N/A UI refactor
• [@Gonals / @neil-marcellini] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[michaelhaxhiu]

Question - should we be paying @aimane-chnaif for C+ review of the PR?
cc @neil-marcellini for bud check :)

[neil-marcellini]

Yes! @aimane-chnaif did a wonderful job reviewing.

[michaelhaxhiu]

invited to job - https://www.upwork.com/jobs/~01c2d7197fc8a993a4

[bumpedyou]

Hello, I am Georg Nebe from Germany. I have just seen your project on upwork platfrom so I am excited to propose my solution for the migration to React Native to solve the issues raised in the GitHub issue linked above. I have reviewed the issue and have thoroughly examined the project's React Native architecture and features. My solution to this issue involves adapting the existing codebase to React Native, ensuring compatibility with all platforms, improving the user interface, and addressing any performance issues.
Here are my additional contact information:
Email: [email protected]
Skype: live:.cid.3dc806afe79f42e8
Telegram: LoveCoder829
Hope to hearing from you soon. Thanks

[melvin-bot]

📣 @Naruto0829! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[bumpedyou]

Here is my upwork profile
https://www.upwork.com/freelancers/~01267d36486ded1ab5

[michaelhaxhiu]

Paid, closing.

This is already done/fixed. @Naruto0829 check out jobs available for hire below:

https://github.com/Expensify/App/issues?q=is%3Aopen+is%3Aissue+label%3A%22Help+Wanted%22

Also I recommend reading our contributing.md guide so you know how to contribute. Your proposal above wouldn't be viable or detailed enough to get hired.

https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md

[zhangchunsheng]

Paid, closing.

This is already done/fixed. @Naruto0829 check out jobs available for hire below:

https://github.com/Expensify/App/issues?q=is%3Aopen+is%3Aissue+label%3A%22Help+Wanted%22

Also I recommend reading our contributing.md guide so you know how to contribute. Your proposal above wouldn't be viable or detailed enough to get hired.

https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md

I read it on upwork. It seemed that it is done.

[melvin-bot]

📣 @zhangchunsheng! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[zhangchunsheng]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~010e62c725dbc630bf

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!