[HOLD for payment 2023-04-13] Editing Workspace Name does not navigate you back to the previous Settings page

[Gonals]

Coming from #16768, as it is a very similar issue (but in a different spot)

---

Action Performed:

1. Open a workspace
2. Go to General Settings
3. Change the room name
4. Click save

Expected Result:

The name should be updated and the settings modal should close.

Actual result:

The name updates but the settings modal does not close.

Workaround:

None

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f751877ab50c048c
• Upwork Job ID: 1643180539784540160
• Last Price Increase: 2023-04-04

[MelvinBot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01f751877ab50c048c

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

[Gonals]

Removing C+, as it is a very minor fix

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.95-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Navigate back after saving Workspace changes #16903

If no regressions arise, payment will be issued on 2023-04-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Gonals] The PR that introduced the bug has been identified. Link to the PR:
  No real issue that was introduced. This was just the original behavior and it is no longer consistent with similar flows in other parts. Skipping the sections below too

• [@Gonals] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

• [@Gonals] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

• [@adelekennedy] Determine if we should create a regression test for this bug.

• [@Gonals] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[adelekennedy]

I don't think any payment is due here (or in the related issue) @Gonals am I missing something?

[Gonals]

I don't think any payment is due here (or in the related issue) @Gonals am I missing something?

Nope, you are 100% right!