Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] mWeb/Chrome - Account Management page - Required section name is not visible #12210

Closed
kbecciv opened this issue Oct 27, 2022 · 35 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Oct 27, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #12147

Action Performed:

  1. Go to https://help.expensify.com/articles/other/Account-Management#how-do-i-contact-my-account-manager

Expected Result:

"How do I contact my account manager?" section of "Account Management" page should be displayed with section name visible.

Actual Result:

"How do I contact my account manager?" section name is not visible once user is landed on the page. Only Android / Chrome. Not repro with iOS / Safari nor Windows / Chrome

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web - Android/Chrome

Version Number: 1.2.19.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5795351_video_2022-10-27_13-29-37.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 27, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2022

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@sophiepintoraetz
Copy link
Contributor

Hmm, I'm not sure if this needs to go to engineering or if we can close as a part of the Deploy list above - but swinging over in case.

@melvin-bot
Copy link

melvin-bot bot commented Oct 28, 2022

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@sophiepintoraetz sophiepintoraetz added Weekly KSv2 and removed Daily KSv2 labels Oct 28, 2022
@sophiepintoraetz
Copy link
Contributor

@michaelhaxhiu michaelhaxhiu added Daily KSv2 and removed Weekly KSv2 labels Nov 3, 2022
@michaelhaxhiu
Copy link
Contributor

Switching back to daily per the standard bugzero process. Also just a friendly reminder to keep the pressure on to find a contributor and get this one closed out!

A few questions to help move this forward.

  1. Is this external or internal?
  2. If it's external let's post it to upwork. If it's internal and reproducible, let's label as demolition to get movement.

@sophiepintoraetz
Copy link
Contributor

I'd love to hear from @marcochavezf and @johncschuster to confirm that it's a quick fix from https://github.com/Expensify/Expensify/issues/188579

@marcochavezf
Copy link
Contributor

marcochavezf commented Nov 4, 2022

Oh I missed the previous ping, I think it can be external. Contributors can follow these instructions to run the site locally. I tried to update some of the tocbot settings, but I have no luck. Probably it's a CSS style issue.

@sophiepintoraetz
Copy link
Contributor

Bumping @roryabraham 🙏

@roryabraham
Copy link
Contributor

Sorry for the delay, marking this as external

@roryabraham roryabraham added Reviewing Has a PR in review External Added to denote the issue can be worked on by a contributor and removed Reviewing Has a PR in review labels Nov 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 7, 2022

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Nov 7, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 7, 2022

Triggered auto assignment to @Julesssss (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title mWeb/Chrome - Account Management page - Required section name is not visible [$250] mWeb/Chrome - Account Management page - Required section name is not visible Nov 7, 2022
@sophiepintoraetz
Copy link
Contributor

Job posted!

@kzhein
Copy link
Contributor

kzhein commented Nov 8, 2022

Proposal

Expensify help website has a fixed navigation menu for small screens that usually remains fixed at the top of the page. When you use the URL anchor, the browser window will scroll itself (instantly) to bring anchor at the top of the page, leaving the content behind the fixed navigation menu.

Solution:

expensify.mp4

For small screens, we can use :before pseudo element and giving it a height, which pushes up the size of the header, then use negative margin to yank it back up into place

#content-area {
  h1::before, h2::before {
    @include maxBreakpoint($breakpoint-tablet) {
            display: block;
            content: ' ';
            height: 80px; 
            margin-top: -80px;
            visibility: hidden;
    }
  }
}

@melvin-bot
Copy link

melvin-bot bot commented Nov 8, 2022

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@sobitneupane
Copy link
Contributor

Workaround proposed by @kzhein looks good and test well.

As I am not very much familiar with "help.expensify.com", I am not sure if there is any other direct ways to achieve the result.

cc: @Julesssss

🎀👀🎀 C+ reviewed

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 9, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 9, 2022

📣 @kzhein You have been assigned to this job by @Julesssss!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@kzhein
Copy link
Contributor

kzhein commented Nov 9, 2022

Thanks! I have sent a pull request and applied the job in Upwork.

@Julesssss Julesssss added the Reviewing Has a PR in review label Nov 11, 2022
@sophiepintoraetz
Copy link
Contributor

sophiepintoraetz commented Nov 21, 2022

@Julesssss - are we waiting on a review from @Gonals in the linked PR for this issue to close it out?

@Gonals
Copy link
Contributor

Gonals commented Nov 22, 2022

@Julesssss - are we waiting on a review from @Gonals in the linked PR for this issue to close it out?

Nope! That PR is already merged and deployed. This issue should be closed, right @Julesssss ?

@Julesssss
Copy link
Contributor

Ah, the automated message didn't appear but we are still 2 days away from payment. Then we can close the issue.

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@kzhein
Copy link
Contributor

kzhein commented Nov 24, 2022

@sophiepintoraetz May I know when can I expect the payment?

@sophiepintoraetz
Copy link
Contributor

Hey @kzhein - typically we need 7 days from the PR being merged but you're all set! Just processed payment through Upwork now 👍 @sobitneupane - I've hired you for the job if you want to accept the contract!

@sobitneupane
Copy link
Contributor

@sophiepintoraetz Accepted offer. This issue is also eligible for 50% bonus since the PR was merged within 3 days.

@roryabraham
Copy link
Contributor

Dropping this since @Julesssss has been acting as the CME for this issue.

@roryabraham roryabraham removed their assignment Nov 28, 2022
@kzhein
Copy link
Contributor

kzhein commented Nov 29, 2022

@sophiepintoraetz Received the payment but I think you forgot the eligible 50% bonus.

@sophiepintoraetz
Copy link
Contributor

Sorry @kzhein - I was out yesterday - I'll look into this once I have a chance!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@sophiepintoraetz
Copy link
Contributor

@kzhein - thanks for your patience! I created a separate job I hired you for with the bonus of $125 - see here!

@sophiepintoraetz
Copy link
Contributor

All paid!

@sobitneupane
Copy link
Contributor

@sophiepintoraetz Accepted offer. This issue is also eligible for 50% bonus since the PR was merged within 3 days.

@sophiepintoraetz I am not paid yet. I have accepted the offer.

@sophiepintoraetz
Copy link
Contributor

Hired you for the job @sobitneupane - here's the link!

@sobitneupane
Copy link
Contributor

@sophiepintoraetz Thanks. (250$+125$) is due.

@sophiepintoraetz
Copy link
Contributor

All set @sobitneupane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

10 participants