-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] mWeb/Chrome - Account Management page - Required section name is not visible #12210
Comments
Triggered auto assignment to @sophiepintoraetz ( |
Hmm, I'm not sure if this needs to go to engineering or if we can close as a part of the Deploy list above - but swinging over in case. |
Triggered auto assignment to @roryabraham ( |
Actually, cc @marcochavezf and @johncschuster from https://github.com/Expensify/Expensify/issues/188579 |
Switching back to A few questions to help move this forward.
|
I'd love to hear from @marcochavezf and @johncschuster to confirm that it's a quick fix from https://github.com/Expensify/Expensify/issues/188579 |
Oh I missed the previous ping, I think it can be external. Contributors can follow these instructions to run the site locally. I tried to update some of the tocbot settings, but I have no luck. Probably it's a CSS style issue. |
Bumping @roryabraham 🙏 |
Sorry for the delay, marking this as external |
Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
Triggered auto assignment to @Julesssss ( |
ProposalExpensify help website has a fixed navigation menu for small screens that usually remains fixed at the top of the page. When you use the URL anchor, the browser window will scroll itself (instantly) to bring anchor at the top of the page, leaving the content behind the fixed navigation menu. Solution:expensify.mp4For small screens, we can use :before pseudo element and giving it a height, which pushes up the size of the header, then use negative margin to yank it back up into place #content-area {
h1::before, h2::before {
@include maxBreakpoint($breakpoint-tablet) {
display: block;
content: ' ';
height: 80px;
margin-top: -80px;
visibility: hidden;
}
}
} |
Looks like something related to As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our Feel free to drop a note in #expensify-open-source with any questions. |
Workaround proposed by @kzhein looks good and test well. As I am not very much familiar with "help.expensify.com", I am not sure if there is any other direct ways to achieve the result. cc: @Julesssss 🎀👀🎀 C+ reviewed |
📣 @kzhein You have been assigned to this job by @Julesssss! |
Thanks! I have sent a pull request and applied the job in Upwork. |
@Julesssss - are we waiting on a review from @Gonals in the linked PR for this issue to close it out? |
Nope! That PR is already merged and deployed. This issue should be closed, right @Julesssss ? |
Ah, the automated message didn't appear but we are still 2 days away from payment. Then we can close the issue. |
Issue not reproducible during KI retests. (First week) |
@sophiepintoraetz May I know when can I expect the payment? |
Hey @kzhein - typically we need 7 days from the PR being merged but you're all set! Just processed payment through Upwork now 👍 @sobitneupane - I've hired you for the job if you want to accept the contract! |
@sophiepintoraetz Accepted offer. This issue is also eligible for 50% bonus since the PR was merged within 3 days. |
Dropping this since @Julesssss has been acting as the CME for this issue. |
@sophiepintoraetz Received the payment but I think you forgot the eligible 50% bonus. |
Sorry @kzhein - I was out yesterday - I'll look into this once I have a chance! |
Issue not reproducible during KI retests. (Second week) |
All paid! |
@sophiepintoraetz I am not paid yet. I have accepted the offer. |
Hired you for the job @sobitneupane - here's the link! |
@sophiepintoraetz Thanks. (250$+125$) is due. |
All set @sobitneupane |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Issue found when executing PR #12147
Action Performed:
Expected Result:
"How do I contact my account manager?" section of "Account Management" page should be displayed with section name visible.
Actual Result:
"How do I contact my account manager?" section name is not visible once user is landed on the page. Only Android / Chrome. Not repro with iOS / Safari nor Windows / Chrome
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.2.19.1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5795351_video_2022-10-27_13-29-37.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: