Deploy Checklist: New Expensify 2022-10-26

[OSBotify]

Release Version: 1.2.20-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Refactor createIOUTransaction to RequestMoney #10843
• perf: reanimated 3 upgrade #11567
• Offline feedback and errors for optimistic room rows #11655
• Add Workspace name label next to room name in the chats list #11799
• fix highlighted headers in LHN #11868
• Create The-Free-Plan.md #11933
• [No QA] Migrate workflows to stop using set-output #11957
• Update expensify-common #11996
• fix "clicking on emoji picker in edit message closes the keyboard" #12051
• Fix option row user select #12059
• Remove unwanted password field in add bank account page #12077
• Reduce the character limit for messages to avoid hitting Auth limit #12087
• Add focus indicator for edit composer #12095
• [No QA] Clean up jest mocks #12097
• Add FullPageOfflineBlockingView for Requestor Onfido step #12113
• Fix for: Web - Workspace - Console error when creating and deleting a workspace #12121
• Upgrade react-native-svg to 13.4.0 #12140
• adding Account MGMT doc #12147
• Revert "Upgrade react-native-svg to 13.4.0" #12176
• Use Onyx set if creating new report #12192
• Add loading spinner to IOUConfirmationList #12216

Deploy Blockers:

• [$250] Android - Workspace - App is crashed when creating a new Workspace #12171
• Connect Bank Account - App is crashed when adding a Verified Bank Account #12172
• Android - LHN - App is crashed when tap on Send/Request money #12173
• Request money - The intermediate page is visible when requesting money to a new user #12183
• Split Request - User receives a long wait time with no spinner after tapping on "Split Bill" #12204

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.20-0 🚀

[Julesssss]

I checked off #12173 #12171 which have been resolved by this PR

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.20-1 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.20-1 has been deployed to staging 🎉

[Julesssss]

@Expensify/applauseleads could you please retest #12172? Thanks

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Julesssss]

I checked off #12172, as it was also fixed by #12176

[mvtglobally]

@Julesssss @chiragsalian
Team is still working on the regression. Few notes

#11868 (comment)
PR #12077 is blocked on IOS and Android due to the VBA issue (see tread https://expensify.slack.com/archives/C01GTK53T8Q/p1666811104732769)
PR #12087 is failing due to #12207. Issue is repro in PROD. Checking off
PR #12113 is failing due to #12194. We are not able to check in PROD, pls double check
PR #12147 is failing #12210, repro in PROD. Checking off

[mvtglobally]

@Julesssss @chiragsalian
Regression is completed

2 Blockers
#12183
#12204

And last open issues are
#11868 (comment)
PR #12077 is blocked on IOS and Android due to the VBA issue (see tread https://expensify.slack.com/archives/C01GTK53T8Q/p1666811104732769)
PR #12113 is failing due to #12194. We are not able to check in PROD, pls double check

[chiragsalian]

I started discussing about the points in #expensify-open-source (comment)

We just pushed a CP for #12183, once its on staging we'll ask you guys to re-test the issue.

Still working on the other points.

[chiragsalian]

Checking off #12077 since there isn't much we can do on it right now. As long as its tested on web, mobile web and desktop we should be good to go.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.20-2 🚀

[chiragsalian]

Checking off #11868 as per comment.

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.20-2 has been deployed to staging 🎉

[Luke9389]

I ran a passing Web QA for 12113

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.20-3 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.20-3 has been deployed to staging 🎉

[OSBotify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[chiragsalian]

oops i misclicked earlier.

Anyway checking off #12192, #12216, #12183 and #12204 as its been tested by QA here and here.

[chiragsalian]

App timing dashboard has a bit of spike on ios but its hard to say if its something introduced here. I'm checking this.

There are a number of crashes for SVGLength.java line 111, but this is only on version 1.2.20-0, and so i believe a fix was CP'd since i don't see it on a newer build. Checking it off.

[chiragsalian]