Deploy Checklist: New Expensify 2022-09-01

[OSBotify]

Release Version: 1.1.96-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Refactor Edit and Delete Report Comment #9532
• update react-native-svg version #10334
• Refactor Session.resendValidationLink and the ResendValidationForm to use the new API #10556
• Simplify new line indicator and message badge #10582
• [No QA] Remove unneeded suppression #10678
• Remove workspace chats on delete even if they are pinned #10689
• Upgrade RNGH to 2.6.0 to fix default max distance for long press on Android #10717
• Remove unused function #10726
• [NO QA]Remove misplaced method #10728
• [NoQA] Improve the Pattern B docs #10743
• Fix for delete comment refactor #10764
• Revert "update react-native-svg version" #10775
• Use sequenceNumber and reportActionID for now #10779
• Show deleted messages with a strike-through when offline #10780
• Add resendLink message to successData #10783

Deploy Blockers:

• [HOLD for payment 2022-10-20] [$250] Android/IOS - Attachment - PDF file is not shown in Preview Page, only 0.00% is shown #10442
• Android - Chat - App crashed after send a second message #10751
• Web- Conversation - Attachment removal is not smooth, still appears after deleted #10753
• Log in - Missing re-sent link message when you click Forgot password #10754
• Android - Crash after upload image attachment #10756
• Android - App crashed after tap the back button in offline mode #10757
• Android - Chat - App crashed after send a emoji #10759

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.96-0 🚀

[mvtglobally]

Regression is completed

Deploy Blockers
#10442
#10751
#10753
#10754
#10756
#10757
#10759

PR #9532 is failing due to #10751 & #10766
PR #10556 is failing due to #10758.
PR #10582 & #10717 are failing due to #10751

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.96-1 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.96-1 has been deployed to staging 🎉

[roryabraham]

Tried reverting #10582 and was able to reproduce the crash on that branch, so I don't think it's that

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.96-2 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.96-2 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.96-4 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.96-4 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.96-5 🚀

[luacmartins]

@mvtglobally @kbecciv can you still reproduce the following issues?

• Android - Chat - App crashed after send a second message #10751
• Android - Chat - App crashed after send a emoji #10759
• Android - Crash after upload image attachment #10756

We are having issues reproducing these locally and on staging.

[mvtglobally]

@luacmartins we will check and confirm in a bit

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.96-5 has been deployed to staging 🎉

[mvtglobally]

We are re-testing PR #9532, #10582 & #10717 which were failing due to #10751
Checking CP as well

[AndrewGable]

Thank you @mvtglobally, we have completed all blockers so please let us know when you are finished!

[Julesssss]

This Firebase Exception is possibly a new regression. 12 unique users and only occuring on this version.

The alternative is that this was one of the reported blockers, is now fixed, and can be closed.

[AndrewGable]

Exported here and fixed already! 🎉

[mvtglobally]

Checking off #9532 & #10717

CP #10780 is failing due to #10799. Its a new feature, Ok to checkoff or mark as Blocker?
I dont think we can test #10764. Ok to check off?

@AndrewGable @roryabraham Can you confirm if #10582 was reverted? Should we test it or can just check off?

[AndrewGable]

#10582 was not reverted and should be tested still. Looking into others!

[AndrewGable]

Checked off #10764 as it was reverted shortly after.

[PauloGasparSv]

I think we can check #10780 off as @mvtglobally said and address that on the follow up issue if that's ok! Because the offline-first and delete functionality are working despite the message quickly popping up before being deleted when toggling!

Is that ok?

[mvtglobally]

PR #10556 is failing due to #10758. Still seems to be broken

Recording.1064.mp4

Screen_Recording_20220902-111516_Chrome.mp4

[luacmartins]

@mvtglobally can you test with an account that hasn't attempted to send the link more than 3 times? I think the reason the message doesn't show up is because we never send the link since that account is throttled.

For now, the error message won't show up the first time you click Forgot? since we will fix the error message in a follow up PR in our API layer.

[mvtglobally]

Checking off #10582 - retest pass.
#10556 is the last one left.

[bondydaa]

yep agreed can you confirm that you're not actually throttled in these #10748 (comment)?

Users are throttled after on the 4th attempt within 5 minutes of each other: so you should be able to click it 3 times and get magic links sent and then a 4th should give you that error.

[mvtglobally]

New account seem ok. When you use re-set password it is showing automatically the message,

But can you guys re-validate this last one internally as well, to make sure we dont miss anything here.

Recording.1065.mp4

[bondydaa]

When you use re-set password it is showing automatically the message

yep that's expected for now will be fixed on #10785.

I just tried this myself (hours after those initial attempts) and got the same message for those accounts which is unexpected

logs https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%22744792dfda233839-SAN%22)+AND+timestamp:[2022-09-02T15:20:33.984Z+TO+2022-09-02T17:20:33.984Z]&index=logs_expensify-018393

744792dfda233839-SAN | 2022-09-02 16:20:33 987 | [email protected] | undefined | db1.sjc | [audit] User just got throttled because they reached 3 number of calls for resendValidateCode

[email protected]:~$ sudo readdb.sh -line "SELECT name, value FROM nameValuePairs WHERE name like 'private_throttleAttempts_resendValidateCode%' and accountid=12451070;"
 name = private_throttleAttempts_resendValidateCode
value = [1662135599059757,1662135601949561,1662135632575400,1662135633987843]

 name = private_throttleAttempts_resendValidateCode-212.231.184.140
value = [1662135599059930,1662135601949716,1662135632575547]

 name = private_throttleAttempts_resendValidateCode-99.235.190.147
value = [1662050591612159]

But if anything this is something broken in auth not this code - new dot is actually handling this well and showing us the error now 🎉

[mvtglobally]

@bondydaa Are we ok to check it off then?

[bondydaa]

hm strange and I just tried again and it worked fine for [email protected]

looking at the db again, the throttle attempts had been cleared out and only 2 show now

[email protected]:~$ sudo readdb.sh -line "SELECT name, value FROM nameValuePairs WHERE name like 'private_throttleAttempts_resendValidateCode%' and accountid=12451070;"
 name = private_throttleAttempts_resendValidateCode
value = [1662138028209658,1662138031477769]

 name = private_throttleAttempts_resendValidateCode-212.231.184.140
value = [1662138028209808,1662138031477953]

 name = private_throttleAttempts_resendValidateCode-99.235.190.147
value = [1662050591612159]
[email protected]:~$

Just copying over from Slack I tested with a brand new account

1. created a new account, clicked resend validation link 3 times and got this
2. on the 4th click of resend validation link got the error as expected:
3. And got 4 emails as expected (when you first create the account we send you a validation link and then the 3 from the repeated clicking of resend validation link).

So yep I think 👍 to check it off.

[mvtglobally]

We are good to 🚀 then

[Julesssss]

Awesome, we're good to deploy first thing this morning.

• I rechecked the timing dash and there are no noticeable timing regressions.
• I see one new exception here. I haven't been able to reproduce yet as the logs are a bit vague. Posting in #deployer before I move forward.

[Julesssss]

From testing the app I'm still unable to find any exception. Going to move forward as Applause's checklist would have picked up on any noticable regression.

[Julesssss]