Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(date-picker): improve date-picker a11y #6715

Merged
merged 6 commits into from
Apr 5, 2023
Merged

fix(date-picker): improve date-picker a11y #6715

merged 6 commits into from
Apr 5, 2023

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Apr 1, 2023 •
edited
Loading

Related Issue: #5570

Summary

This improves calcite-date-picker a11y by:

  • moving gridcell role to calcite-date-picker-month component rendering (day wrapper)
  • adding button role to calcite-date-picker-day
  • providing a locale-aware aria-label to calcite-date-picker-day describing the associated day

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Apr 1, 2023
jcfranco
jcfranco commented Apr 4, 2023
View reviewed changes
src/components/date-picker/date-picker.tsx
/**
* Active start date.
*/
@State() activeStartDate: Date;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved and sorted to proper section.

@jcfranco jcfranco marked this pull request as ready for review April 4, 2023 23:05
@jcfranco jcfranco requested a review from a team as a code owner April 4, 2023 23:05
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 4, 2023
driskull
driskull approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit 74b3b96 into master Apr 5, 2023
@jcfranco jcfranco deleted the jcfranco/5570-improve-date-picker-a11y branch April 5, 2023 16:19
@jcfranco jcfranco mentioned this pull request Apr 24, 2023
Merged
jcfranco added a commit that referenced this pull request Apr 24, 2023
@jcfranco
fix(date-picker): fix range highlight style regression (#6836)
9c519fb 
**Related Issue:** N/A

## Summary

This fixes a visual regression introduced by
#6715.
@geospatialem geospatialem mentioned this pull request Oct 26, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2023 April Priorities - No breaking c...
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @driskull