Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[input-date-picker] Using range, 2nd input's dropdown icon shows first date-picker #7965

Closed
2 of 4 tasks
arjanvanzutphen opened this issue Oct 9, 2023 · 5 comments
Closed
2 of 4 tasks
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Hub Issues logged by ArcGIS Hub team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality Professional Services - Services Delivery Issues logged by Professional Services - Services Delivery team members regression Issues that are caused by changes in a release, but were working before that.

Comments

@arjanvanzutphen
Copy link

arjanvanzutphen commented Oct 9, 2023

Check existing issues

Actual Behavior

Clicking on the second dropdown icon (marked yellow) shows the date-picker underneath the first input element
image

Note that clicking on the second input-date-picker element itself shows the date-picker underneath the second input element.
Behavior occurs with vertical and horizontal layout.

Expected Behavior

Clicking on the second dropdown icon (marked yellow) in the second input element shows the first date-picker underneath

Reproduction Sample

See documentation (https://developers.arcgis.com/calcite-design-system/components/input-date-picker/)

Reproduction Steps

  1. Go the the input-date-picker documentation sample
  2. Enable the range property. A second input element for an end date appears
  3. Make sure the input elements are not active. Click somewhere outside the input-date-picker element(s). Active elements are blue bordered, like below:
    image
  4. Click on the dropdown icon in the second input element.
  5. The date-picker components will appear underneath the first input element.

Reproduction Version

1.9.0

Relevant Info

No response

Regression?

1.3.0, likely from #6715

Priority impact

p4 - not time sensitive

Impact

The end user must select the input element itself to have the date-picker component appear.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/eslint-plugin-calcite-components

Esri team

Professional Services - Services Delivery

@arjanvanzutphen arjanvanzutphen added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Oct 9, 2023
@github-actions github-actions bot added Professional Services - Services Delivery Issues logged by Professional Services - Services Delivery team members calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Oct 9, 2023
@abp6318
Copy link
Contributor

abp6318 commented Oct 26, 2023

Dropping a comment as we found this bug over on Hub Discovery as well and are hoping it can be bumped up in time sensitivity. We are looking to have this fixed for our current milestone. Also leaving this here: https://devtopia.esri.com/dc/hub/issues/8086

@thomas-hervey looks like this issue has been logged by another team already.

@geospatialem geospatialem added the ArcGIS Hub Issues logged by ArcGIS Hub team members. label Oct 26, 2023
@geospatialem
Copy link
Member

Thanks @arjanvanzutphen and @abp6318 - it looks like this was introduced in 1.3.0 from #6715 for some a11y improvements back in March. We haven't yet triaged this issue into a milestone, but we've got some full initiatives throughout the remainder of 2023.

If we allocated this to early 2024, would that work time-wise with your teams?

@geospatialem geospatialem added regression Issues that are caused by changes in a release, but were working before that. p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 3 A day or two of work, likely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Oct 26, 2023
@geospatialem
Copy link
Member

This is still present as of 2.1.0-next.11 via https://codepen.io/geospatialem/pen/eYxqxYj, but seems to perform better than it had initially.

@jcfranco jcfranco self-assigned this Jan 4, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jan 4, 2024
jcfranco added a commit that referenced this issue Jan 4, 2024
…date-picker (#8554)

**Related Issue:** #7965

## Summary

This fixes an issue that caused the start date picker to be toggled when
the end date icon was clicked.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 4, 2024
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jan 4, 2024

🍠 Verified locally on main

@DitwanP DitwanP closed this as completed Jan 4, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Hub Issues logged by ArcGIS Hub team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality Professional Services - Services Delivery Issues logged by Professional Services - Services Delivery team members regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Development

No branches or pull requests

5 participants