fix(combobox): listbox item focused with home or end now scrolls into view #4304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
…irst/last-item-into-focus-scroll-into-view
jcfranco
reviewed
Apr 1, 2022
…age to the very top, End scrolls to bottom
…irst/last-item-into-focus-scroll-into-view
…tbox to be consistent Dropdown behavior
…irst/last-item-into-focus-scroll-into-view
…irst/last-item-into-focus-scroll-into-view
…irst/last-item-into-focus-scroll-into-view
…irst/last-item-into-focus-scroll-into-view
…ptive per comments
…irst/last-item-into-focus-scroll-into-view
jcfranco
approved these changes
Apr 11, 2022
| @@ -514,7 +516,7 @@ describe("calcite-combobox", () => { | |||
| await page.waitForChanges(); | |||
| expect(await page.evaluate(() => document.activeElement.id)).toBe("myCombobox"); | |||
|
|
|||
| await page.keyboard.press("ArrowDown"); | |||
| await page.keyboard.press("Space"); | |||
There was a problem hiding this comment.
Do we also need a test for ArrowDown opening the menu?
There was a problem hiding this comment.
💡 There is a test below this one that does that.
…irst/last-item-into-focus-scroll-into-view
Elijbet
deleted the
elijbet/4265-fix-combobox-home/end-bring-first/last-item-into-focus-scroll-into-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #4265
Summary
This discussion prompted several changes for Combobox to be consistent with the Dropdown behavior:
Includes adjustments to related failing tests.