Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: [combobox]: rework pageUp/down scroll test to do away with the fixed delay. #4391

Open
Elijbet opened this issue Apr 11, 2022 · 0 comments
Open

Refactor: [combobox]: rework pageUp/down scroll test to do away with the fixed delay. #4391

Elijbet opened this issue Apr 11, 2022 · 0 comments
Labels
0 - new New issues that need assignment. estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Apr 11, 2022

Description

Follow up to issue #4304

Specifically Keyboard Navigation test "when the combobox is focused & closed, Page up/down (fn arrow up/down) scrolls up and down the page"

PageDown/Up scroll test fails if not delayed. Implemented page.waitForTimeout(500) to make it pass. WaitForChanges() won’t work either.

Needs to be revisited because we want to avoid delays with magic numbers in tests and keep the tests running as fast as possible.

Proposed Advantages

Using fixed delays makes the test brittle, since the time it takes for what we're waiting for to happen could change. It might be better to rework it to use waitForSelector. Waiting for something to appear will make the amount of time variable and test more stable.

Which Component

combobox

Relevant Info

No response
@Elijbet Elijbet added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 11, 2022
@Elijbet Elijbet changed the title Combobox: rework pageUp/down scroll test to do away with the fixed delay. Refactor: [combobox]: rework pageUp/down scroll test to do away with the fixed delay. Apr 12, 2022
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Oct 16, 2023
@geospatialem geospatialem added spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. and removed spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. labels Dec 6, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Dec 6, 2023
@jcfranco jcfranco added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 22, 2024
@jcfranco jcfranco removed this from the 2024-05-28 - May Main Release milestone Apr 22, 2024
@geospatialem geospatialem added this to the 2025-03-25 - Mar Release milestone Sep 6, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 6, 2024
@geospatialem geospatialem added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jcfranco @alisonailea @geospatialem @Elijbet @DitwanP