-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tooltip): close tooltips on prevented pointer move events #11557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
approved these changes
Feb 14, 2025
benelan
added a commit
that referenced
this pull request
Feb 17, 2025
* origin/dev: (171 commits) chore(tip-manager): drop empty spec test (#11568) chore: release next feat(chip): enhance component's interactivity states (#11538) chore: release next fix(tooltip): close tooltips on prevented pointer move events (#11557) chore: release main (#11561) chore: release next revert: build(deps): update arcgis to ^4.33.0-next.13 (#11539) (#11559) fix(dialog, modal, popover, sheet): fixes an issue that caused extra containers to be lost after internal trap updates (#11556) chore: release main (#11551) build(deps): update arcgis to ^4.33.0-next.13 (#11539) chore: release next fix(input-date-picker): allow navigating between months using chevron actions in Safari (#11547) chore: release next fix(dialog, modal, sheet): preserve focus-trap extra containers across internal trap updates (#11548) chore: release next feat(segmented-control-item): enhance component's interactivity states (#11477) chore: release next refactor: drop deprecated loadable component utilities (#11479) docs: link to package readmes from root readme (#11531) ...
benelan
added a commit
that referenced
this pull request
Feb 18, 2025
* origin/dev: (27 commits) build(deps): update eslint (#11487) build(deps): update arcgis to ^4.32.0-next.136 (#11542) build(deps): update dependency postcss to v8.5.2 (#11553) build(deps): update dependency turbo to v2.4.2 (#11554) build: update browserslist db (#11571) build(deps): update dependency rollup to v4.34.7 (#11572) chore(tip-manager): drop empty spec test (#11568) chore: release next feat(chip): enhance component's interactivity states (#11538) chore: release next fix(tooltip): close tooltips on prevented pointer move events (#11557) chore: release main (#11561) chore: release next revert: build(deps): update arcgis to ^4.33.0-next.13 (#11539) (#11559) fix(dialog, modal, popover, sheet): fixes an issue that caused extra containers to be lost after internal trap updates (#11556) chore: release main (#11551) build(deps): update arcgis to ^4.33.0-next.13 (#11539) chore: release next fix(input-date-picker): allow navigating between months using chevron actions in Safari (#11547) chore: release next ...
benelan
pushed a commit
that referenced
this pull request
Feb 19, 2025
**Related Issue:** #11541 ## Summary - Close tooltip even when `pointer-move` event is cancelled - Add test
benelan
pushed a commit
that referenced
this pull request
Feb 19, 2025
**Related Issue:** #11541 ## Summary - Close tooltip even when `pointer-move` event is cancelled - Add test
Merged
benelan
pushed a commit
that referenced
this pull request
Feb 19, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 3.0.3</summary> ## [3.0.3](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-02-19) ### Bug Fixes * **dialog, modal, popover, sheet:** Restore `focusTrapDisabled` reactiveness ([#11586](#11586)) ([a32dd7e](a32dd7e)) * **input-date-picker:** No longer close while navigating months with chevron actions ([#11525](#11525)) ([acf5824](acf5824)) * **slider:** Ensure histograms with non-zero min are displayed correctly ([#11587](#11587)) ([9bb32f6](9bb32f6)) * **tooltip:** Close tooltips on prevented pointer move events ([#11557](#11557)) ([470df20](470df20)) </details> <details><summary>@esri/calcite-components-react: 3.0.3</summary> ## [3.0.3](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-02-19) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 3.0.2 to 3.0.3 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
benelan
pushed a commit
that referenced
this pull request
Feb 19, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 3.0.3</summary> [3.0.3](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-02-19) * **dialog, modal, popover, sheet:** Restore `focusTrapDisabled` reactiveness ([#11586](#11586)) ([a32dd7e](a32dd7e)) * **input-date-picker:** No longer close while navigating months with chevron actions ([#11525](#11525)) ([acf5824](acf5824)) * **slider:** Ensure histograms with non-zero min are displayed correctly ([#11587](#11587)) ([9bb32f6](9bb32f6)) * **tooltip:** Close tooltips on prevented pointer move events ([#11557](#11557)) ([470df20](470df20)) </details> <details><summary>@esri/calcite-components-react: 3.0.3</summary> [3.0.3](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-02-19) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 3.0.2 to 3.0.3 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
benelan
added a commit
that referenced
this pull request
Feb 19, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 3.0.3</summary> [3.0.3](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-02-19) * **dialog, modal, popover, sheet:** Restore `focusTrapDisabled` reactiveness ([#11586](#11586)) ([a32dd7e](a32dd7e)) * **input-date-picker:** No longer close while navigating months with chevron actions ([#11525](#11525)) ([acf5824](acf5824)) * **slider:** Ensure histograms with non-zero min are displayed correctly ([#11587](#11587)) ([9bb32f6](9bb32f6)) * **tooltip:** Close tooltips on prevented pointer move events ([#11557](#11557)) ([470df20](470df20)) </details> <details><summary>@esri/calcite-components-react: 3.0.3</summary> [3.0.3](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2025-02-19) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 3.0.2 to 3.0.3 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Calcite Admin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Bug reports for broken functionality. Issues should include a reproduction of the bug.
skip visual snapshots
Pull requests that do not need visual regression testing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #11541
Summary
pointer-move
event is cancelled