Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input-date-picker): allow navigating between months using chevron actions in Safari #11547

Merged
merged 3 commits into from
Feb 14, 2025
Merged

fix(input-date-picker): allow navigating between months using chevron actions in Safari #11547

merged 3 commits into from
Feb 14, 2025

Conversation

anveshmekala
Copy link
Contributor

Related Issue: #11544

Summary

No longer closes the input-date-picker when navigating between month using chevron actions.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 13, 2025
@anveshmekala anveshmekala marked this pull request as ready for review February 13, 2025 23:50
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 13, 2025
jcfranco
jcfranco approved these changes Feb 14, 2025
View reviewed changes
packages/calcite-components/src/components/action/action.tsx
@@ -295,6 +295,7 @@ export class Action extends LitElement implements InteractiveComponent {
disabled={disabled}
id={buttonId}
ref={this.buttonEl}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an explainer comment here?

@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 14, 2025
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 14, 2025
@geospatialem geospatialem added this to the 3.0.0 Patch - 2025-02-13 milestone Feb 14, 2025
@anveshmekala anveshmekala merged commit e248837 into dev Feb 14, 2025
14 checks passed
@anveshmekala anveshmekala deleted the anveshmekala/11544-fix-date-picker-chevron-safari branch February 14, 2025 03:16
benelan pushed a commit that referenced this pull request Feb 14, 2025
@anveshmekala @benelan
fix(input-date-picker): allow navigating between months using chevron…
8a0f71f 
… actions in Safari (#11547)

**Related Issue:** #11544 

## Summary

No longer closes the `input-date-picker` when navigating between month
using chevron actions.
benelan pushed a commit that referenced this pull request Feb 14, 2025
@anveshmekala @benelan
fix(input-date-picker): allow navigating between months using chevron…
9b8c02e 
… actions in Safari (#11547)

**Related Issue:** #11544 

## Summary

No longer closes the `input-date-picker` when navigating between month
using chevron actions.
@calcite-admin calcite-admin mentioned this pull request Feb 14, 2025
Merged
benelan pushed a commit that referenced this pull request Feb 14, 2025
@calcite-admin
chore: release main (#11551)
1258e22 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 3.0.1</summary>

##
[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2025-02-14)


### Bug Fixes

* **dialog, modal, sheet:** Preserve focus-trap extra containers across
internal trap updates
([#11548](#11548))
([4e421b7](4e421b7))
* **input-date-picker:** Allow navigating between months using chevron
actions in Safari
([#11547](#11547))
([9b8c02e](9b8c02e))
* **list, block-group:** Drag menu 'Move to' actions broken when list
elements have explicit ids
([#11515](#11515))
([e0daf83](e0daf83))
</details>

<details><summary>@esri/calcite-components-react: 3.0.1</summary>

##
[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2025-02-14)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.0.0 to 3.0.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
benelan pushed a commit that referenced this pull request Feb 14, 2025
@calcite-admin @benelan
chore: release main (#11551)
61188f3 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 3.0.1</summary>

[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2025-02-14)

* **dialog, modal, sheet:** Preserve focus-trap extra containers across
internal trap updates
([#11548](#11548))
([4e421b7](4e421b7))
* **input-date-picker:** Allow navigating between months using chevron
actions in Safari
([#11547](#11547))
([9b8c02e](9b8c02e))
* **list, block-group:** Drag menu 'Move to' actions broken when list
elements have explicit ids
([#11515](#11515))
([e0daf83](e0daf83))
</details>

<details><summary>@esri/calcite-components-react: 3.0.1</summary>

[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2025-02-14)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.0.0 to 3.0.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@benelan benelan mentioned this pull request Feb 14, 2025
Merged
benelan added a commit that referenced this pull request Feb 14, 2025
@benelan @calcite-admin
chore: release main (#11551)
08e7b31 
🤖 I have created a release *beep* *boop*

---

<details><summary>@esri/calcite-components: 3.0.1</summary>


[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2025-02-14)

* **dialog, modal, sheet:** Preserve focus-trap extra containers across
internal trap updates
([#11548](#11548))

([4e421b7](4e421b7))
* **input-date-picker:** Allow navigating between months using chevron
actions in Safari
([#11547](#11547))

([9b8c02e](9b8c02e))
* **list, block-group:** Drag menu 'Move to' actions broken when list
elements have explicit ids
([#11515](#11515))

([e0daf83](e0daf83))
</details>

<details><summary>@esri/calcite-components-react: 3.0.1</summary>


[3.0.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2025-02-14)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 3.0.0 to 3.0.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Calcite Admin <[email protected]>
benelan added a commit that referenced this pull request Feb 17, 2025
@benelan
Merge remote-tracking branch 'origin/dev' into 6646-advanced-table
542ed9a 
* origin/dev: (171 commits)
  chore(tip-manager): drop empty spec test (#11568)
  chore: release next
  feat(chip): enhance component's interactivity states (#11538)
  chore: release next
  fix(tooltip): close tooltips on prevented pointer move events (#11557)
  chore: release main (#11561)
  chore: release next
  revert: build(deps): update arcgis to ^4.33.0-next.13 (#11539) (#11559)
  fix(dialog, modal, popover, sheet): fixes an issue that caused extra containers to be lost after internal trap updates (#11556)
  chore: release main (#11551)
  build(deps): update arcgis to ^4.33.0-next.13 (#11539)
  chore: release next
  fix(input-date-picker): allow navigating between months using chevron actions in Safari (#11547)
  chore: release next
  fix(dialog, modal, sheet): preserve focus-trap extra containers across internal trap updates (#11548)
  chore: release next
  feat(segmented-control-item): enhance component's interactivity states (#11477)
  chore: release next
  refactor: drop deprecated loadable component utilities (#11479)
  docs: link to package readmes from root readme (#11531)
  ...
benelan added a commit that referenced this pull request Feb 18, 2025
@benelan
Merge remote-tracking branch 'origin/dev' into benelan/cleanup-cc-readme
31e74e0 
* origin/dev: (27 commits)
  build(deps): update eslint (#11487)
  build(deps): update arcgis to ^4.32.0-next.136 (#11542)
  build(deps): update dependency postcss to v8.5.2 (#11553)
  build(deps): update dependency turbo to v2.4.2 (#11554)
  build: update browserslist db (#11571)
  build(deps): update dependency rollup to v4.34.7 (#11572)
  chore(tip-manager): drop empty spec test (#11568)
  chore: release next
  feat(chip): enhance component's interactivity states (#11538)
  chore: release next
  fix(tooltip): close tooltips on prevented pointer move events (#11557)
  chore: release main (#11561)
  chore: release next
  revert: build(deps): update arcgis to ^4.33.0-next.13 (#11539) (#11559)
  fix(dialog, modal, popover, sheet): fixes an issue that caused extra containers to be lost after internal trap updates (#11556)
  chore: release main (#11551)
  build(deps): update arcgis to ^4.33.0-next.13 (#11539)
  chore: release next
  fix(input-date-picker): allow navigating between months using chevron actions in Safari (#11547)
  chore: release next
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@anveshmekala anveshmekala

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
3.0.0 Patch - 2025-02-13
Development

Successfully merging this pull request may close these issues.
3 participants
@anveshmekala @jcfranco @geospatialem