refactor(action-group)!: remove deprecated layout property #10792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
eriklharper
changed the title
eriklharper
changed the title
jcfranco
requested changes
Nov 19, 2024
packages/calcite-components/src/components/action-group/action-group.tsx
Outdated
Show resolved
Hide resolved
|
@eriklharper Can you use the |
eriklharper
changed the title
github-actions
bot
added
the
refactor
jcfranco
added
the
skip visual snapshots
jcfranco
approved these changes
Nov 20, 2024
github-actions
bot
added this to the 2024-11-26 - 3.0.0 Nov Breaking Change Milestone milestone
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
**Related Issue:** #9173 ## Summary BREAKING CHANGE: Removes the deprecated `layout` property by converting it to an internal property. Developers will need to replace `calcite-action-group`'s `layout` property with it's parent's `layout` property (i.e., parent `action-pad` or `action-bar`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
refactor(action-group)!: remove deprecated layout property
Related Issue: #9713
Summary
BREAKING CHANGE: Removes the deprecated
layoutproperty by converting it to an internal property.Developers will need to replace
calcite-action-group'slayoutproperty with it's parent'slayoutproperty (i.e., parentaction-padoraction-bar).END_COMMIT_OVERRIDE