Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List]: add mode prop for choosing between flat and nested lists #9173

Closed
2 of 6 tasks
ashetland opened this issue Apr 23, 2024 · 5 comments
Closed
2 of 6 tasks

[List]: add mode prop for choosing between flat and nested lists #9173

ashetland opened this issue Apr 23, 2024 · 5 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. c-list Issues that pertain to the calcite-list component Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. p - high Issue should be addressed in the current milestone, impacts component or core functionality p3 - want for upcoming milestone User set priority status of p3 - want for upcoming milestone ready for dev Issues ready for development implementation.
Milestone
2024-11-26 - 3.0....

Comments

@ashetland
Copy link
Contributor

ashetland commented Apr 23, 2024 •
edited
Loading

Check existing issues

Description

A way to control nesting behavior in List. Nested list items need to hold space for the expand button, but this space is undesirable in lists that, base on workflow, will never have nested items.

This would be a breaking change and should be paired with #7100.

Acceptance Criteria

Add a mode="flat" (default) | "nested" property.

In flat, Lists are rendered flat, without collapsible nesting.

In nested, a blank space is reserved for the expand button in every item.

Before/after example:
CleanShot 2024-11-20 at 13 02 04@2x

Relevant Info

cc @driskull @jcfranco

Which Component

List
List Item

Example Use Case

No response

Priority impact

p3 - want for upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@ashetland ashetland added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 23, 2024
@github-actions github-actions bot added p3 - want for upcoming milestone Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. labels Apr 23, 2024
@ashetland ashetland added the breaking change Issues and pull requests with code changes that are not backwards compatible. label Apr 23, 2024
This was referenced Apr 23, 2024
Closed
Closed
@geospatialem geospatialem added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Apr 26, 2024
@macandcheese macandcheese added the c-list Issues that pertain to the calcite-list component label May 1, 2024
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@geospatialem geospatialem added this to the 2024-11-19 - Nov Release milestone Jun 18, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jun 18, 2024
@aPreciado88 aPreciado88 self-assigned this Nov 1, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Nov 1, 2024
@aPreciado88 aPreciado88 added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 15, 2024
@ashetland ashetland added design Issues that need design consultation prior to development. ready for dev Issues ready for development implementation. and removed design Issues that need design consultation prior to development. labels Nov 18, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

This was referenced Nov 19, 2024
Merged
Merged
eriklharper added a commit that referenced this issue Nov 20, 2024
@eriklharper
refactor(action-group)!: remove deprecated layout property (#10792)
a4d8538 
**Related Issue:** #9173

## Summary

BREAKING CHANGE: Removes the deprecated `layout` property by converting
it to an internal property.

Developers will need to replace `calcite-action-group`'s `layout`
property with it's parent's `layout` property (i.e., parent `action-pad`
or `action-bar`).
@github-actions github-actions bot added the p3 - want for upcoming milestone User set priority status of p3 - want for upcoming milestone label Nov 20, 2024
@ashetland ashetland removed the impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone label Nov 20, 2024
@ashetland
Copy link
Contributor Author

Updated the description to include a before/after screenshot using the current build of List. Spacing will be improved with #7100.

eriklharper added a commit that referenced this issue Nov 20, 2024
@eriklharper
refactor(shell-panel)!: remove deprecated properties (#10794)
8254164 
**Related Issue:** #9173

## Summary

BREAKING CHANGE: Removes the following deprecated properties from
`calcite-shell-panel`: `detachedHeightScale`, `detached` and the
`--calcite-shell-panel-detached-max-height` CSS property.

Developers will need to replace `calcite-shell-panel`'s
`detachedHeightScale` and `detached` properties with `heightScale` and
`displayMode`.
@jcfranco jcfranco assigned driskull and unassigned eriklharper Nov 22, 2024
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 2 - in development Issues that are actively being worked on. labels Nov 22, 2024
driskull added a commit that referenced this issue Nov 23, 2024
@driskull
feat(list): add mode property to choose between flat and nested lists #…
9352339 
…9173
@driskull driskull mentioned this issue Nov 23, 2024
Merged
@geospatialem geospatialem assigned jcfranco and unassigned jcfranco Nov 25, 2024
driskull added a commit that referenced this issue Nov 25, 2024
@driskull
feat(list)!: add displayMode property to choose between flat and nest…
832f2c9 
…ed lists (#10852)

**Related Issue:** #9173

## Summary

- add `displayMode` property to choose between flat and nested lists
- update demos
- update stories
- add tests

BREAKING CHANGE: Choose a `displayMode` of "nested" or "flat" according
to space and nesting requirements.
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned driskull Nov 25, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Nov 25, 2024

🍡 Verified locally on dev

@DitwanP DitwanP closed this as completed Nov 25, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 25, 2024
@geospatialem
Copy link
Member

For documentation purposes later, here's a codepen sample in 3.0.0-next.29: https://codepen.io/geospatialem/pen/MYggPPV. cc @DitwanP

<calcite-list display-mode="nested">

benelan pushed a commit that referenced this issue Feb 8, 2025
@eriklharper @benelan
refactor(action-group)!: remove deprecated layout property (#10792)
77c16ef 
**Related Issue:** #9173

## Summary

BREAKING CHANGE: Removes the deprecated `layout` property by converting
it to an internal property.

Developers will need to replace `calcite-action-group`'s `layout`
property with it's parent's `layout` property (i.e., parent `action-pad`
or `action-bar`).
benelan pushed a commit that referenced this issue Feb 8, 2025
@eriklharper @benelan
refactor(shell-panel)!: remove deprecated properties (#10794)
fd73980 
**Related Issue:** #9173

## Summary

BREAKING CHANGE: Removes the following deprecated properties from
`calcite-shell-panel`: `detachedHeightScale`, `detached` and the
`--calcite-shell-panel-detached-max-height` CSS property.

Developers will need to replace `calcite-shell-panel`'s
`detachedHeightScale` and `detached` properties with `heightScale` and
`displayMode`.
benelan pushed a commit that referenced this issue Feb 8, 2025
@driskull @benelan
feat(list)!: add displayMode property to choose between flat and nest…
41283df 
…ed lists (#10852)

**Related Issue:** #9173

## Summary

- add `displayMode` property to choose between flat and nested lists
- update demos
- update stories
- add tests

BREAKING CHANGE: Choose a `displayMode` of "nested" or "flat" according
to space and nesting requirements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. c-list Issues that pertain to the calcite-list component Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. p - high Issue should be addressed in the current milestone, impacts component or core functionality p3 - want for upcoming milestone User set priority status of p3 - want for upcoming milestone ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
8 participants
@jcfranco @eriklharper @driskull @macandcheese @geospatialem @DitwanP @ashetland @aPreciado88