Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tokens)!: correct space and size tokens #10726

Closed
wants to merge 29 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
4abe6f3
refactor: migrate to Lumina
maxpatiiuk Oct 22, 2024
855765e
move dev deps to root
jcfranco Oct 23, 2024
e09beea
fix scripts and update storybook to leverage vite build
jcfranco Oct 23, 2024
9528fad
fix import/order error
jcfranco Oct 23, 2024
8bd3b3d
add missing and bump react output deps
jcfranco Oct 23, 2024
ade98fe
drop angular wrapper
jcfranco Oct 23, 2024
4a12a0d
update lockfile
jcfranco Oct 23, 2024
73dcb44
dedupe deps
jcfranco Oct 23, 2024
cfb5aed
remove ignore lines for @stencil-community/eslint-plugin rules
jcfranco Oct 23, 2024
fd54377
make messages internal
jcfranco Oct 23, 2024
6ccb86b
drop private keyword from internal messages prop
jcfranco Oct 23, 2024
116b62d
use focusFirstTabbable instead of delegatesFocus
jcfranco Oct 23, 2024
598eed8
move vitest as a dev dep for lumina smartness
jcfranco Oct 24, 2024
8525786
chore: bump arcgis dependencies to next-8
maxpatiiuk Oct 24, 2024
271e0ec
tidy up
jcfranco Oct 25, 2024
c3fb0c5
drop unnecessary react-wrapper patch
jcfranco Oct 25, 2024
4f5cff7
drop invalid rules and update rest
jcfranco Oct 29, 2024
ca6284b
update VSCode settings to ensure TS consistency
jcfranco Oct 29, 2024
2815c9e
fix eslint-plugin-calcite-components build output
jcfranco Oct 29, 2024
4b299e2
WIP: convert dimension type to rem but rem calc is off
alisonailea Nov 13, 2024
6037eb2
Revert "WIP: convert dimension type to rem but rem calc is off"
alisonailea Nov 14, 2024
c1ae71b
chore(token-transformer): add pxToRem helper
alisonailea Nov 14, 2024
39c6562
fix(size): align core token size “category” with “type”
alisonailea Nov 14, 2024
62d0f12
fix(size)!: correct size tokens
alisonailea Nov 14, 2024
213b585
fix(space)!: correct space tokens
alisonailea Nov 14, 2024
b5dcd39
test(tokens): update snapshot
alisonailea Nov 14, 2024
718b476
fix(tokens): remove extra fixed size tokens
alisonailea Nov 14, 2024
d2672dc
fix(tokens): remove extra fixed size tokens
alisonailea Nov 14, 2024
b859435
test(tokens): update snapshot
alisonailea Nov 14, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 1 addition & 2 deletions .github/workflows/issue-notifications.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
steps:
- uses: actions/checkout@v4

- name : "Assign for verification"
- name: "Assign for verification"
if: github.event.label.name == '3 - installed'
uses: actions/github-script@v7
env:
Expand Down Expand Up @@ -50,4 +50,3 @@ jobs:
script: |
const action = require('${{ github.workspace }}/.github/scripts/notifyAboutNewComponent.js')
await action({github, context, core})

3 changes: 2 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@
"html.customData": [
"./packages/calcite-components/dist/extras/vscode-data.json",
"./node_modules/@esri/calcite-components/dist/extras/vscode-data.json"
]
],
"typescript.tsdk": "node_modules/typescript/lib"
}
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ Calcite follows [conventional commits](https://www.conventionalcommits.org/en/v1
Contributions should adhere to the `<type>(<scope>): <descriptive summary>` format and include the following:

- [Convention type](#convention-type)
- [Scope of change](#scope-of-change), *optional*
- [Scope of change](#scope-of-change), _optional_
- [Descriptive commit subject](#descriptive-commit-subject)

Check out the [contribution example](#contribution-example) for a formatted example, and explore [breaking change formatting](#breaking-changes) for consideration during Calcite's breaking change releases.
Expand All @@ -240,7 +240,7 @@ Contributions must adhere to **one** of the following conventions:

### Scope of change

*Optional*. Most contributions will include a scope, such as a component, multiple components, test(s), or utilities. For example:
_Optional_. Most contributions will include a scope, such as a component, multiple components, test(s), or utilities. For example:

- `text-area`
- `dropdown, dropdown-group, dropdown-item`
Expand Down
2 changes: 1 addition & 1 deletion documentation/monorepo.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ Make the following changes and submit a PR:
1. In [`release-please-config.json`](https://github.com/Esri/calcite-design-system/blob/dev/release-please-config.json) under the `packages` field, add the new package's path as well as any package-specific configurations. The only required field is the package's name, taken from the `name` field in its `package.json`.
1. If the new package needs to be linked to Calcite Component's version, add its name to the `LINKED_VERSIONS_TRACKING_PACKAGES` array in [`support/syncLinkedPackageVersions.ts`](https://github.com/Esri/calcite-design-system/blob/dev/support/syncLinkedPackageVersions.ts).
1. Potentially rename the new package's NPM scripts so they match the pipeline names in `turbo.json` (build, test, clean, etc.). Note: having all of the NPM scripts that are specified in `turbo.json` is not required.
1. If present and when possible, the `test` NPM script should *not* build first. Turbo will make sure the `build` script runs first and will cache the results.
1. If present and when possible, the `test` NPM script should _not_ build first. Turbo will make sure the `build` script runs first and will cache the results.
1. Potentially rename directories for consistency with the other packages:

- `src/` - source code
Expand Down
Loading