fix(tokens)!: correct space and size tokens #10726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonailea
requested review from
jcfranco,
benelan and
geospatialem
as code owners
This reverts commit 2b1764d.
BREAKING CHANGES moves all old pixel based size tokens to a “fixed” category and marks them for deprecation. new default size tokens are different sizes new default size tokens convert to REMs when built for web platforms
BREAKING CHANGES moves all old pixel based space tokens to a “fixed” category and marks them for deprecation. new default space tokens are different values new default space tokens convert to REMs when built for web platforms
alisonailea
force-pushed
the
astump/10012-10014-space-size-tokens
branch
from
46b2afd to
b859435
Compare
|
closing in favor of not messed up merge conflicts PR #10727 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10012 #10014
Summary
Corrects space and size tokens to align with the Calcite UI Kit and uses REM based tokens for the web platform token output.
New tokens
calcite-space-none: 0;
calcite-space-md-plus: 0.875rem;
calcite-space-sm-plus: 0.625rem;
BREAKING CHANGES
Size
calcite-size-xxl: 2.75rem; // 44px was 24px
calcite-size-xl: 2rem; // 32px was 20px
calcite-size-lg: 1.5rem; // 24px was 16px
calcite-size-md-plus: 1.25rem; // 20px was 14px
calcite-size-md: 1rem; // 16px was 12px
calcite-size-sm: 0.5rem; // 8px was 6px
Space
calcite-space-lg: 1rem // 16px was 14px
calcite-space-xl: 1.25rem; // 20px was 16px
calcite-space-xxl: 1.5rem; // 24px was 20px
Pixel based tokens are now categorized under "fixed"
calcite-size-fixed-xxxl: 32px; // deprecated
calcite-size-fixed-xxl: 24px; // deprecated
calcite-size-fixed-xl: 20px; // deprecated
calcite-size-fixed-lg: 16px; // deprecated
calcite-size-fixed-md-plus: 14px; // deprecated
calcite-size-fixed-md: 12px; // deprecated
calcite-size-fixed-sm-plus: 10px; // deprecated
calcite-size-fixed-sm: 8px; // deprecated
calcite-size-fixed-xs: 6px; // deprecated
calcite-size-fixed-xxs: 4px; // deprecated
calcite-size-fixed-xxxs: 2px; // deprecated
calcite-space-fixed-lg: 14px; // deprecated
calcite-space-fixed-md: 12px; // deprecated
calcite-space-fixed-sm: 8px; // deprecated
calcite-space-fixed-xl: 16px; // deprecated
calcite-space-fixed-xs: 6px; // deprecated
calcite-space-fixed-xxl: 20px; // deprecated
calcite-space-fixed-xxs: 4px; // deprecated
calcite-space-fixed-xxxl: 32px; // deprecated