Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Color Picker] Hue thumb handle partially hidden under swatch #7005

Closed
geospatialem opened this issue May 23, 2023 · 3 comments
Closed

[Color Picker] Hue thumb handle partially hidden under swatch #7005

geospatialem opened this issue May 23, 2023 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2023 July Priorities

Comments

@geospatialem
Copy link
Member

Actual Behavior

The thumb handle on the color-picker is partially hidden under the swatch.

image

Expected Behavior

The thumb should fall within the slider bounds, but still map to the edges.

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/color-picker/#sample

Reproduction Steps

  1. Open the sample
  2. Observe when the color is to the far left the handle is partially covered by the swatch

Reproduction Version

1.4.0

Relevant Info

No response

Regression?

1.3.1

Priority impact

p2 - want for current milestone

Impact

No response

Esri team

ArcGIS Map Viewer
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - high Issue should be addressed in the current milestone, impacts component or core functionality 1 - assigned Issues that are assigned to a sprint and a team member. labels May 23, 2023
@github-actions github-actions bot added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. labels May 23, 2023
@ashetland ashetland mentioned this issue Jun 12, 2023
Closed
4 tasks
@ashetland
Copy link
Contributor

Discovered some related issues that are present at each scale, but most pronounced on scale="s". See the attached screen recording.

  • Using a mouse, the farthest right extent of the sliders cannot be reached
  • The opacity slider doesn't respond to arrow keys
  • Hue slider nitpick: I think a more expected UX is for the hue slider to range from 0 to 360, not 0 to 359.
CleanShot.2023-06-14.at.14.40.23.mp4

@jcfranco jcfranco mentioned this issue Jul 31, 2023
Merged
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 1, 2023
jcfranco added a commit that referenced this issue Aug 3, 2023
@jcfranco
fix(color-picker): draw slider thumbs within bounds (#7398)
2f37854 
**Related Issue:** #7005

## Summary

This addresses slider thumbs appearing cut off.

This also ensures the max hue slider value doesn't overlap with 0 and
adds a util to map a value between ranges.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 3, 2023
@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Aug 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 3, 2023
@geospatialem
Copy link
Member Author

Verified in 1.5.0-next.36

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2023 July Priorities
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @ashetland