Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epic: Updates to Color Picker #7163

Closed
2 of 4 tasks
ashetland opened this issue Jun 12, 2023 · 5 comments
Closed
2 of 4 tasks

Epic: Updates to Color Picker #7163

ashetland opened this issue Jun 12, 2023 · 5 comments
Assignees
@geospatialem
Labels
1 - assigned Issues that are assigned to a sprint and a team member. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Milestone
2025-03-25 - 3.1....

Comments

@ashetland
Copy link
Contributor

ashetland commented Jun 12, 2023 •
edited
Loading

Description

The design phase for adding alpha channel support to Color Picker (issue #749) proposed additional improvements that were intended to be tackled after the initial alpha channel support was implemented. This issue is to document the remaining tasks to complete. cc: @fr

Acceptance Criteria

Relevant Info

For full details, updated Figma file can be found here.

Note: the square color field mockups below would need approval from teams, but may also be unnecessary it the color field could be made responsive to container size (#9415).

Historical screenshots of first pass on design below. Updated mocks are available in the associated issues above.
image
image
image
image

Which Component

Color Picker

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Esri team

Calcite (design)
@ashetland ashetland added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 12, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone Calcite (design) Issues logged by Calcite designers. labels Jun 12, 2023
@ashetland ashetland added ready for dev Issues ready for development implementation. figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists labels Jun 14, 2023
@ashetland
Copy link
Contributor Author

@macandcheese @SkyeSeitz The above comment has been updated to reflect the changes we discussed.

@ashetland
Copy link
Contributor Author

Note, the square color field above should have the lowest priority. Will need feedback from teams as it may have adverse affects on layouts.

@macandcheese
Copy link
Contributor

macandcheese commented Aug 8, 2023 •
edited
Loading

Maybe a way for users to customize height of color graph? The square ones end up being significantly “taller” than previously - perhaps height graph prop for S/M/L? I think using css vars not possible with the color graph.

The previous heights are probably more expected, having it square just adds “more granular choice” to the graph but not sure that is actually needed.

@ashetland
Copy link
Contributor Author

ashetland commented Aug 8, 2023 •
edited
Loading

Yeah I could see that working well.

@brittneytewks brittneytewks added design Issues that need design consultation prior to development. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists labels Dec 11, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 10, 2024
@jcfranco jcfranco added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. label May 6, 2024
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@jcfranco jcfranco self-assigned this May 23, 2024
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. and removed 0 - new New issues that need assignment. labels May 23, 2024
@geospatialem geospatialem added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label May 24, 2024
@geospatialem geospatialem mentioned this issue May 24, 2024
Closed
8 tasks
This was referenced May 24, 2024
Open
Open
Closed
@geospatialem geospatialem changed the title Updates to Color Picker Epic: Updates to Color Picker May 24, 2024
@geospatialem geospatialem added this to the 2024-08-27 - Aug Release milestone Jun 18, 2024
@geospatialem geospatialem removed needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p3 - want for upcoming milestone labels Jun 18, 2024
@geospatialem
Copy link
Member

Most of the efforts above have been tackled, with the exception of #9413 and #9414. We will track the efforts in the linked issuea separately, but the overall epic above is being closed out with the majority of effort complete. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
1 - assigned Issues that are assigned to a sprint and a team member. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. epic Large scale issues to be broken up into sub-issues and tracked via sprints and/or project. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Projects
None yet
Milestone
2025-03-25 - 3.1.0 Mar Release
Development

No branches or pull requests
5 participants
@jcfranco @macandcheese @geospatialem @ashetland @brittneytewks