Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add extra Kubernetes node pools #35

Merged
merged 2 commits into from
Nov 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions azurerm/modules/azurerm-aks/aks.tf
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,20 @@ resource "azurerm_kubernetes_cluster" "default" {
]
}

# Create additional node pools if they have been specified
resource "azurerm_kubernetes_cluster_node_pool" "additional" {
for_each = var.aks_node_pools

name = each.key
kubernetes_cluster_id = azurerm_kubernetes_cluster.default[0].id
vm_size = each.value.vm_size

enable_auto_scaling = each.value.auto_scaling
min_count = each.value.min_nodes
max_count = each.value.max_nodes
node_count = each.value.min_nodes
}

# perform lookup on existing ACR for stages where we don't want to create an ACR
data "azurerm_container_registry" "acr_registry" {
count = var.create_acr ? 0 : 1
Expand Down
2 changes: 1 addition & 1 deletion azurerm/modules/azurerm-aks/identity.tf
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ resource "azurerm_key_vault" "default" {
}

resource "azurerm_user_assigned_identity" "default" {
count = var.create_user_identiy ? 1 : 0
count = var.create_user_identity ? 1 : 0
location = var.resource_group_location
resource_group_name = azurerm_resource_group.default.name
name = var.resource_namer
Expand Down
6 changes: 3 additions & 3 deletions azurerm/modules/azurerm-aks/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,15 @@ output "aks_system_identity_principal_id" {
### used for AAD Pod identity binding ###
#########################################
output "aks_default_user_identity_name" {
value = var.create_user_identiy ? azurerm_user_assigned_identity.default.0.name : ""
value = var.create_user_identity ? azurerm_user_assigned_identity.default.0.name : ""
}

output "aks_default_user_identity_id" {
value = var.create_user_identiy ? azurerm_user_assigned_identity.default.0.id : ""
value = var.create_user_identity ? azurerm_user_assigned_identity.default.0.id : ""
}

output "aks_default_user_identity_client_id" {
value = var.create_user_identiy ? azurerm_user_assigned_identity.default.0.client_id : ""
value = var.create_user_identity ? azurerm_user_assigned_identity.default.0.client_id : ""
}

output "aks_ingress_private_ip" {
Expand Down
13 changes: 12 additions & 1 deletion azurerm/modules/azurerm-aks/vars.tf
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ variable "resource_group_tags" {
###########################
# IDENTITY SETTINGS
##########################
variable "create_user_identiy" {
variable "create_user_identity" {
description = "Creates a User Managed Identity - which can be used subsquently with AAD pod identity extensions"
type = bool
default = true
Expand Down Expand Up @@ -241,6 +241,17 @@ variable "node_count" {
default = 0
}

variable "aks_node_pools" {
type = map(object({
vm_size = string,
auto_scaling = bool,
min_nodes = number,
max_nodes = number
}))
description = "Additional node pools as required by the platform"
default = {}
}

# DEFAULTS TO 30 if not overwritten
variable "os_disk_size" {
type = number
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ module "aks_bootstrap" {
subnet_names = ["k8s1"]
aks_ingress_private_ip = cidrhost(cidrsubnet(var.vnet_cidr.0, 4, 0), -3)
private_cluster_enabled = false
create_user_identiy = var.create_user_identiy
create_user_identity = var.create_user_identity
enable_auto_scaling = true
log_application_type = var.log_application_type
key_vault_name = var.key_vault_name
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@ output "aks_system_identity_principal_id" {

### Identity ###
output "aks_default_user_identity_name" {
value = var.create_user_identiy ? module.aks_bootstrap.aks_default_user_identity_name : ""
value = var.create_user_identity ? module.aks_bootstrap.aks_default_user_identity_name : ""
}

output "aks_default_user_identity_id" {
value = var.create_user_identiy ? module.aks_bootstrap.aks_default_user_identity_id : ""
value = var.create_user_identity ? module.aks_bootstrap.aks_default_user_identity_id : ""
}

output "aks_default_user_identity_client_id" {
value = var.create_user_identiy ? module.aks_bootstrap.aks_default_user_identity_client_id : ""
value = var.create_user_identity ? module.aks_bootstrap.aks_default_user_identity_client_id : ""
}

output "aks_ingress_private_ip" {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ variable "create_aksvnet" {
default = true
}

variable "create_user_identiy" {
variable "create_user_identity" {
type = bool
default = true
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ variable "create_aksvnet" {
default = true
}

variable "create_user_identiy" {
variable "create_user_identity" {
type = bool
default = true
}