Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add extra Kubernetes node pools #35

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

russellseymour
Copy link
Contributor

📲 What

Added a new resource to the AKS module which allows additional node pools to be added to the cluster.

Corrected a spelling mistake in the variable for create_identity.

🤔 Why

In some situations it is beneficial to have multiple node pools in a Kubernetes cluster. The reason for this is so that the control plane can be separated from the application pods that are deployed. This means that the application node pools can have a different VM size associated with them as well as having some isolation between the processed.

Having create_identiy as the variable name meant that things kept going wrong when the variable was spelt correctly

🛠 How

Added a new resource in the module to create node pools. The has an accompanying variable which is a map of objects so that mutiple pools can be created with different settings. The default value is:

aks_node_pools = {}

However if a pool was to be created it can be done like so:

variable "aks_node_pools" {
  type = map(object({
    vm_size      = string,
    auto_scaling = bool,
    min_nodes    = number,
    max_nodes    = number
  }))
  description = "Additional node pools as required by the platform"

  default = {
    application = {
      vm_size      = "Standard_DS2_v2"
      auto_scaling = true
      min_nodes    = 3
      max_nodes    = 10
    }
  }
}

Renamed the incorrect variable using a global search and replace aross the repository.

👀 Evidence

This has been tested using Infracost to create a plan file for an environment and determine the cost of the infrastructure.

🕵️ How to test

Notes on how a reviewer can test the changes, e.g. how to run the tests.

✅ Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

@ElvenSpellmaker ElvenSpellmaker merged commit b77491d into master Nov 1, 2022
@ElvenSpellmaker ElvenSpellmaker deleted the feature/aks-node-pools branch November 1, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants