Ability to add extra Kubernetes node pools #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Added a new resource to the AKS module which allows additional node pools to be added to the cluster.
Corrected a spelling mistake in the variable for
create_identity
.🤔 Why
In some situations it is beneficial to have multiple node pools in a Kubernetes cluster. The reason for this is so that the control plane can be separated from the application pods that are deployed. This means that the application node pools can have a different VM size associated with them as well as having some isolation between the processed.
Having
create_identiy
as the variable name meant that things kept going wrong when the variable was spelt correctly🛠 How
Added a new resource in the module to create node pools. The has an accompanying variable which is a map of objects so that mutiple pools can be created with different settings. The default value is:
aks_node_pools = {}
However if a pool was to be created it can be done like so:
Renamed the incorrect variable using a global search and replace aross the repository.
👀 Evidence
This has been tested using Infracost to create a plan file for an environment and determine the cost of the infrastructure.
🕵️ How to test
Notes on how a reviewer can test the changes, e.g. how to run the tests.
✅ Acceptance criteria Checklist