simulation testing

[gjermundgaraba]

No description provided.

[codecov]

Codecov Report

Base: 73.26% // Head: 61.10% // Decreases project coverage by -12.17% ⚠️

Coverage data is based on head (367a677) compared to base (40fa6fd).
Patch coverage: 27.13% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #469       +/-   ##
===========================================
- Coverage   73.26%   61.10%   -12.17%     
===========================================
  Files          56       63        +7     
  Lines        4346     5797     +1451     
===========================================
+ Hits         3184     3542      +358     
- Misses        996     2071     +1075     
- Partials      166      184       +18     

Flag	Coverage Δ
chain	60.07% <27.13%> (-12.26%)	⬇️
cosmwasm	98.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
chain/app/export.go	0.00% <0.00%> (ø)
chain/app/simulation/state.go	0.00% <0.00%> (ø)
chain/utils/validation.go	100.00% <ø> (ø)
chain/x/plasticcredit/simulation/operations.go	0.00% <0.00%> (ø)
chain/x/plasticcredit/simulation/utils.go	17.94% <17.94%> (ø)
chain/x/plasticcredit/module/module_simulation.go	20.00% <25.00%> (+15.65%)	⬆️
chain/app/simulation/utils.go	33.33% <33.33%> (ø)
chain/x/plasticcredit/keeper/query_server.go	63.75% <53.84%> (+1.94%)	⬆️
chain/x/plasticcredit/keeper/applicant.go	88.46% <62.50%> (-4.73%)	⬇️
chain/x/plasticcredit/keeper/project.go	81.81% <62.50%> (-1.70%)	⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
empowerchain	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 14, 2023 at 8:16PM (UTC)

[ba1ciu]

Overall I don't see anything that would make me suggest keeping it from merging. There's so much of the boilerplate needed in the project that could be just imported from SDK, that makes me feel anxious, but nothing we can do about it, I guess :) Shared some general remarks, questions and ideas in the comments.

Also, maybe we could use SimulationState.AppParams to store seeds/counters that will help finding existing credits easier? json.RawMessage is just a []byte, so potentially we could use it to store all generated denoms/abbrevs/serials in there and pick randomly from it. Not very clean, I know, and not sure if possible, but sounds better than adding logic to the keeper if we don't need it for stuff other than simulation?