Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation testing plasticcredit module #295

Closed
3 tasks done
gjermundgaraba opened this issue Oct 19, 2022 · 3 comments · Fixed by #469
Closed
3 tasks done

Simulation testing plasticcredit module #295

gjermundgaraba opened this issue Oct 19, 2022 · 3 comments · Fixed by #469
Assignees
Labels
C:x/plasticcredit Plastic credit component T:ci T:tests

Comments

@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented Oct 19, 2022

Set up simulation testing for what we have + add it to CI

Reminders:

  • Update CODING_GUIDELINES
  • Add non-determinism and perhaps a short sim test to the regular test pipeline
  • Modules for import/export test
@gjermundgaraba gjermundgaraba self-assigned this Oct 19, 2022
@gjermundgaraba
Copy link
Contributor Author

Will wait for 0.47 as the setup seems to be changing a bit and I don't want to do this multiple times right now.

@gjermundgaraba gjermundgaraba removed their assignment Oct 19, 2022
@gjermundgaraba gjermundgaraba added this to the V1 milestone Nov 16, 2022
@gjermundgaraba
Copy link
Contributor Author

Closing in favor of separate issues

@gjermundgaraba gjermundgaraba closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2022
@gjermundgaraba
Copy link
Contributor Author

There seems to not have been a separate issue :D Reopening!

@gjermundgaraba gjermundgaraba reopened this Feb 4, 2023
@gjermundgaraba gjermundgaraba self-assigned this Feb 4, 2023
@gjermundgaraba gjermundgaraba linked a pull request Feb 10, 2023 that will close this issue
@gjermundgaraba gjermundgaraba changed the title Simulation testing Simulation testing plasticcredit module Feb 15, 2023
@gjermundgaraba gjermundgaraba added the C:x/plasticcredit Plastic credit component label Feb 15, 2023
@gjermundgaraba gjermundgaraba removed this from the V1 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/plasticcredit Plastic credit component T:ci T:tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant