Replace deprecated BigDecimal.new() calls with BigDecimal() #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes this error: ``` Your bundle is locked to psych (3.0.0), but that version could not be found in any of the sources listed in your Gemfile. If you haven't changed sources, that means the author of psych (3.0.0) has removed it. You'll need to update your bundle to a version other than psych (3.0.0) that hasn't been removed in order to install. ``` which happened because psych 3.0.0 was yanked from rubygems: https://rubygems.org/gems/psych/versions
After upgrading to ruby 2.6.1, our application started logging this warning: ``` warning: BigDecimal.new is deprecated; use BigDecimal() method instead. ``` which was being emitted from roxml-4.0.0/lib/roxml/definition.rb:179 So, in this commit I've replaced the deprecated `BigDecimal.new` invocations with invoking the `BigDecimal` method as recommended.
rmacklin
force-pushed
the
fix-BigDecimal-deprecation
branch
from
865e3fa to
7fceacc
Compare
|
The only Travis failure is in the This seems unrelated, and the other builds passed. That said, it might be a good idea to test this gem against more recent ruby versions (potentially replacing the ruby 2.2 and 2.3 builds with ruby 2.5 and 2.6), but we can leave that for another PR. |
|
Thanks! I will work on another PR to get the ruby versions in .travis.yml up to date. |
|
Thanks for merging this @lostapathy! I added a comment on your PR to update Are you able to publish a new patch version with this change? |
|
Gotcha, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to ruby 2.6.1, our application started logging this warning:
which was being emitted from
roxml-4.0.0/lib/roxml/definition.rb:179:roxml/lib/roxml/definition.rb
Line 179 in 9c6e27c
So, in this PR I've replaced the deprecated
BigDecimal.newinvocations with invoking theBigDecimalmethod as recommended.