Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release a new gem version #64

Closed
anaprimawaty opened this issue Apr 11, 2019 · 12 comments
Closed

Please release a new gem version #64

anaprimawaty opened this issue Apr 11, 2019 · 12 comments

Comments

@anaprimawaty
Copy link

Please release a new gem version to accommodate the BigDecimal changes, thanks!

@ianwremmel
Copy link

Are there any plans to release #62?

@ghost
Copy link

ghost commented Nov 25, 2019

@Empact would you have a chance to cut a release soon? The deprecation warning is noisy on ruby 2.6.5 and will block adoption on ruby 2.7.0.

pooriajr added a commit to pooriajr/quickbooks-ruby that referenced this issue Apr 20, 2020
BigDecimal deprecation in ruby 2.7.0 breaks roxml dependency on this gem

ruckus#515
Empact/roxml#64
ruckus pushed a commit to ruckus/quickbooks-ruby that referenced this issue Apr 20, 2020
BigDecimal deprecation in ruby 2.7.0 breaks roxml dependency on this gem

#515
Empact/roxml#64
@jacobjlevine
Copy link

@Empact looks like the fix for this issue is already in master (commit 7fceacc) but hasn't been included in a new gem version. Anything we can do to help with that? It would be great for all us who use quickbooks-ruby to be able to use this gem with Ruby 2.7.

@jacobjlevine
Copy link

@rmacklin thanks for your work on updating this gem last year. Any chance you have some influence here?

@lostapathy
Copy link
Collaborator

Cutting a gem requires the attention of someone listed as an author over on rubygems - which is separate from github privileges.

To work around this, I've been pointing my Gemfile directly at github at the hash including the fixes I needed.

@jacobjlevine
Copy link

@lostapathy thanks for the info! Looks like you're an admin for the github repo. Is @Empact the only author on rubygems? And any insights into why it's taken so long to move this forward?

Also, thanks for the suggestion for the Gemfile. For anyone else here because they use quickbooks-ruby, I added gem 'roxml', github: 'Empact/roxml', ref: '0d6fd8e' and that seems to have fixed errors with quickbooks-ruby and Ruby 2.7.

@lostapathy
Copy link
Collaborator

There's 4 authors listed over on rubygems but I think Empact is by far the most recent person to participate here.

@rmacklin
Copy link
Contributor

rmacklin commented Jun 9, 2020

@rmacklin thanks for your work on updating this gem last year. Any chance you have some influence here?

Unfortunately I can't help either. I've also been using a git ref in my Gemfile to work around the gem not having a new release on rubygems.

@Empact
Copy link
Owner

Empact commented Jun 9, 2020

I can release this today. Does anyone want to step up as a maintainer?

@rmacklin
Copy link
Contributor

I can release this today.

Thank you, that would be great!

Does anyone want to step up as a maintainer?

I would defer to those who already have push access (e.g. @lostapathy).

Even though I was tagged in this thread, I don't really have experience with this gem. It's only in our application as a transitive dependency, so I've never worked with it directly. I opened #62 to fix the BigDecimal deprecations when I was upgrading our application to ruby 2.6 and that small change was the extent of my contributions.

That said, I could help out with cutting and publishing releases.

One thought: asking for a new maintainer might warrant its own dedicated issue which could potentially be linked from the top of the README.

@Empact
Copy link
Owner

Empact commented Jun 10, 2020

Released:
https://rubygems.org/gems/roxml
https://github.com/Empact/roxml/releases/tag/v4.1.0

Let me know if you run into any issues with the release, will be prompt next time.

Thanks all for the help - it takes a village. ;)

@Empact Empact closed this as completed Jun 10, 2020
@jacobjlevine
Copy link

Thanks, @Empact! So appreciate this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants