Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature table maxHeight (#1560) #1674

Merged
merged 3 commits into from
Dec 13, 2016
Merged

Feature table maxHeight (#1560) #1674

merged 3 commits into from
Dec 13, 2016

Conversation

theshem
Copy link
Contributor

@theshem theshem commented Dec 10, 2016 •
edited
Loading

Addressed #1560

  • Make sure you follow Element's Contributing Guide.
  • Make sure you are merging your commits to dev branch.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

@theshem
Copy link
Contributor Author

theshem commented Dec 12, 2016

@QingWei-Li Any thoughts on this?

@Leopoldthecoder
Copy link
Contributor

@HashemQolami Thanks. We'll look into this tomorrow.

@QingWei-Li QingWei-Li merged commit 998dcce into ElemeFE:dev Dec 13, 2016
@theshem theshem deleted the feature-table-maxheight branch December 13, 2016 08:46
@arthurdenner arthurdenner mentioned this pull request Mar 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leopoldthecoder Leopoldthecoder Leopoldthecoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theshem @Leopoldthecoder @QingWei-Li