Table: equal behaviour for height and max-height

[arthurdenner]

Closes #13751.

This PR is an attempt to close the referenced issue since I'm not sure if it breaks something...

Since the max-height is calculated this way, if you specify it with a unit other than px (an integer), it doesn't calculate properly, therefore, doesn't show the scrollbar.

I looked into why it's calculated like that and couldn't figured out, so I tried to replace it with the same calculation used for height and it worked as expected. Even this example, created in the PR that originated the max-height feature, just worked as before.

I checked the documentation after changing the calculation and all the examples are working as before, so it seems to me that the change doesn't break anything, but please review it carefully since I'm not aware of all the edge cases covered by the current calculation.

[element-bot]

Deploy preview for element ready!

Built with commit fbdd002

https://deploy-preview-14660--element.netlify.com

[ziyoung]

@arthurdenner It works for me.

[ziyoung]

I checked the commit records of Table.vue and I think it is ok to do so. This is git blame of Table.vue https://github.com/ElemeFE/element/blame/595271f46332287cfcd42385c5b9ba05927e951d/packages/table/src/table.vue#L339

[zhuxianbin]

There is another bug, set the table of max-height and the height is wrong.

[askart]

Can confirm, all tables' heights are broken

[cjsky666]

There is another bug, only set the table of max-height and the height is wrong

[ziyoung]

When max-height is string, it will cause another bug. https://codepen.io/ziyoung/pen/qwvryL

[fangwenzheng88]

There is another bug，want it back in the next release

[zmyjs]

Why did you do that, this leads to bugs

[iyow]

set max-height then
max-height was forcibly modified to 60px

[gavin1990]

bodyHeight returns the default empty height in case of data loading delay.


example: https://codepen.io/robotss/pen/eaMmaY?&editable=true

[XMoonLights]

set max-height then
max-height was forcibly modified to 60px

I also have this problem, the max-heigth setting is successful, but the wrapper's max-heigth is fixed at 77px.

[LoseyourseIf]

I also have this problem height:'80vh' does not work ! so I used old version '2.7.2' it's ok