Resolve #539, #357 - Fix splash screen interaction causing crashes, ghost dragging, and resizable behavior #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent ghost drag, fix resizable splash screen. Resolves ElectronNET#539, ElectronNET#357 Using the browser-window-focus event would cause the splashScreen to be destroyed early (since regular mouse-focus events would cause the event to be fired). Using the browser-window-created event produces the correct behavior.
|
Please, merge this PR, I have a ticket for this bug in my app ;) |
indiemini
changed the title
|
When will this available official in NuGet package, when will it be released? |
singh7sarb
approved these changes
May 12, 2021
dbphoton
approved these changes
May 12, 2021
|
Would be nice to have a way to manually close the splash screen... |
|
@dbphoton @singh7sarb any ideas when this could be merged? seems like a simple change and it is quite an annoying bug... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #539, #357
Using the
browser-window-focusevent would cause the splashScreen window to be destroyed early (since regular mouse-focus events would cause the event to be fired).Switching to the
browser-window-createdevent produces the correct behavior.