Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interacting with the Splash Screen causes WebApp to exit before reaching main browser window #539

Closed
indiemini opened this issue Feb 17, 2021 · 0 comments · Fixed by #540
Closed

Interacting with the Splash Screen causes WebApp to exit before reaching main browser window #539

indiemini opened this issue Feb 17, 2021 · 0 comments · Fixed by #540
Labels
bug

Comments

@indiemini
Copy link
Contributor

  • Version: 11.5.1

.NET 5, Nodejs v14.15.4

  • Target: Windows x64

Interacting with the splash screen - particularly by clicking on a different window, then clicking back to the splash screen - often causes the entire WebApp to close before launching the main browser window. This issue showed up in the discussion of #357 but wasn't resolved.

Further, the splash screen acts as a normal browser window, and its contents can be dragged (i.e. dragging the splash image to your desktop, creating a .png copy), and can be resized, causing odd behavior.

Steps to Reproduce:

  1. Set a splash image in electron.manifest.json
  2. Interact (click, drag, etc) with it before the main window has loaded/rendered
@indiemini indiemini added the bug label Feb 17, 2021
indiemini added a commit to indiemini/Electron.NET that referenced this issue Feb 17, 2021
@indiemini
Fix splash screen interaction causing crashes, fix splash screen cont…
4596492 
…ent ghost drag, fix resizable splash screen. Resolves ElectronNET#539, ElectronNET#357

Using the browser-window-focus event would cause the splashScreen to be destroyed early (since regular mouse-focus events would cause the event to be fired).

Using the browser-window-created event produces the correct behavior.
@indiemini indiemini mentioned this issue Feb 17, 2021
Merged
GregorBiswanger added a commit that referenced this issue Jul 1, 2021
@GregorBiswanger
Merge pull request #540 from MiniguyBrendan/master
c1b3d42 
Resolve #539, #357 - Fix splash screen interaction causing crashes, ghost dragging, and resizable behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@indiemini