Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update purei9_unofficial and add country code config #75

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

Phype
Copy link
Contributor

@Phype Phype commented Oct 4, 2024

I've fixed the purei9_unoffical library by adding new authentication options.

I'll not implement the new API from https://developer.electrolux.one/ since this is already supported by JohNan/homeassistant-wellbeing#145 now. However, the new API does not support all features yet, so its good to have a fallback.

This should fix #73.

@michaelfuncke
Copy link

So as this pull request has not been merged yet I installed Phype's clone repository via HACS. When trying to authenticate I get the "auth" error, though (email and pw correct).

What have I done wrong?

For me, the option to send the robot to certain zones is important. That's why JohNan's implementation is not suitable for me yet.

@Phype
Copy link
Contributor Author

Phype commented Oct 21, 2024

Maybe you are also affected by Phype/purei9_unofficial#29

To summarize that issue, the new authentication seems to differentiate between user accounts in different geographic zones. It works for me and my account(s) and I haven't had the time to look at it in detail yet.

@joakimjalden
Copy link

joakimjalden commented Oct 21, 2024

For me, the option to send the robot to certain zones is important. That's why JohNan's implementation is not suitable for me yet.

Just FYI, the (Electrolux developer) API that JohNan/homeassistant-wellbeing uses does not at present support the commands needed to send the vacuum to specific zones. I've been in contact with the developers at Electrolux to request that this feature be added. While their response was generally positive they were also upfront about it being a significant effort on their end and thus something that would need to be put against other priorities at the company. We will just have to wait and see if they can do it, after which adding the functionality to HA most likely would be straighforward.

They did however as part of our email conversation ask me to help support to a claim I made that this feature (i.e., zones) was highly requested by the HA community, to which I responded by sending them links to discussions I was aware of on forums and on GitHub, including the Ekman/home-assistant-pure-i9 and the Phype/purei9_unofficial repos. While it is probably not helpful to overload them with emails, I do believe that constructively voicing our wishes for these features, including stable and uniform authentication across geographic regions for the APIs that purei9_unofficial use, in HA forums and also directly to Electrolux could help.

@Phype
Copy link
Contributor Author

Phype commented Oct 29, 2024

It was indeed caused by different region setings. I've updated purei9_unofficial and also the integration to pass an additional configuration parameter (the country code).

The integration needs to be re-initialized (integrations -> Pure i9 -> delete intergretation entry -> re add it) to set this value. The value should be the 2-character country code of your account, i.e. SE for sweden, US, etc, allthough different values will also work as long as they map to the same datacenter.

@michaelfuncke
Copy link

michaelfuncke commented Nov 12, 2024

Great! That worked (country code DE for Germany)! Thank you very much, @Phype!

@Ekman
Copy link
Owner

Ekman commented Nov 13, 2024

Thanks for the PR. I'll review it ASAP

@Ekman Ekman changed the title Update purei9_unofficial Update purei9_unofficial and add country code config Nov 13, 2024
@Ekman Ekman changed the base branch from master to country_code November 13, 2024 16:40
@Ekman Ekman merged commit 75e9980 into Ekman:country_code Nov 13, 2024
0 of 3 checks passed
Ekman added a commit that referenced this pull request Nov 13, 2024
Co-authored-by: Philipp Jeitner <>
Co-authored-by: Niklas Ekman <[email protected]>
Ekman added a commit that referenced this pull request Nov 13, 2024
Co-authored-by: Philipp Jeitner <>
Co-authored-by: Niklas Ekman <[email protected]>
Ekman added a commit that referenced this pull request Nov 13, 2024
Co-authored-by: Philipp Jeitner <>
Co-authored-by: Niklas Ekman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Giving up due to no left retries. Wrong credentials?
4 participants