Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge latest from origin #19

Merged
merged 106 commits into from
Apr 3, 2017
Merged

chore: merge latest from origin #19

merged 106 commits into from
Apr 3, 2017

Conversation

kennethlynne
Copy link

@kennethlynne kennethlynne commented Apr 3, 2017

This change is Reviewable

brianinator and others added 30 commits August 15, 2016 17:35
…#185

Add prop optionTintColor for ActionSheet options text
Now are UUIDs generated with `node-uuid` and is possible to change this
behavior using `messageIdGenerator` prop.
Refactor utils into stand-alone functions
Add prop for tintColor for ActionSheet in Actions FaridSafi#185
Removed a few unnecessarily strict rules, so we're
down to 486 errors now.
Add eslint script (extends airbnb + react + react-native)
Currently the fix is unpublished.
kfiroo and others added 25 commits February 12, 2017 14:44
Added "renderAvatarOnTop" prop to Avatar.js
Remove duplicated enableEmptySections
…text input tool bar can be rendered incorrectly due to the bottom offset
Reset Input Toolbar can over calculate from bottomOffset props
Allow custom styling of buttom container of bubble
fix for _messageContainerRef === null
InteractionManager breaks sometimes, causes hard-to-debug issues
…function-example

Bubble.js: Default value for prop bottomContainerStyle
Export MessageContainer in GiftedChat
…eight

Allow minimum input tool bar height to be configurable in properties
`message.user.avatar` can now be a `number` for `required` images as well as `function` and `string`
# Conflicts:
#	README.md
#	package.json
#	src/GiftedChat.js
#	src/MessageContainer.js
@arealmaas
Copy link

:lgtm:


Review status: 0 of 23 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@sondremare
Copy link

Review status: 0 of 23 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


src/GiftedChat.js, line 504 at r1 (raw file):

  keyboardShouldPersistTaps: Platform.select({
    ios: 'never',
    android: 'always',

Btw, this is what causes the keyboard on Android not to close when tapping outside it. Have no idea why it is like this


Comments from Reviewable

@sondremare
Copy link

:lgtm:


Review status: 0 of 23 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

@kennethlynne kennethlynne merged commit d36299e into master Apr 3, 2017
@kennethlynne kennethlynne deleted the update-package branch April 3, 2017 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.