Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export MessageContainer in GiftedChat #392

Merged
merged 1 commit into from
Mar 27, 2017
Merged

Conversation

brendan-rius
Copy link
Contributor

It was not exported making it harder to customize GifterChat

@kfiroo
Copy link
Collaborator

kfiroo commented Mar 26, 2017

@brendan-rius Hey, I'm wondering, how would you use this?

@brendan-rius
Copy link
Contributor Author

brendan-rius commented Mar 26, 2017

I needed to extend the GiftedChat class directly. Thus I copied the original code of GiftedChat but I needed to import MessageContainer to do this. It was not exported, making it impossible to do something like:

import {
    Actions,
    Avatar,
    Bubble,
    MessageImage,
    MessageText,
    Composer,
    Day,
    InputToolbar,
    LoadEarlier,
    Message,
    MessageContainer, // <---- here
    Send,
    Time,
    GiftedAvatar,
    utils
} from  'react-native-gifted-chat'

class MyCustomGiftedChat extends React.Component {
   // THIS CODE USES MessageContainer
}

@kfiroo
Copy link
Collaborator

kfiroo commented Mar 27, 2017

@brendan-rius Oh, well this is not the common use case :)

@kfiroo kfiroo merged commit 4e9a4aa into FaridSafi:master Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants