Fix failed sync of evm wallets #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
force-pushed
the
paul/fixEvmSync
branch
from
09c7ad5 to
ccd3cbf
Compare
samholmes
requested changes
Nov 13, 2023
src/ethereum/EthereumNetwork.ts
Outdated
| @@ -1733,14 +1739,22 @@ export class EthereumNetwork { | |||
| this.ethNeeds.blockHeightLastChecked, | |||
| BLOCKHEIGHT_POLL_MILLISECONDS, | |||
| preUpdateBlockHeight, | |||
| async () => await this.check('blockheight') | |||
| async () => { | |||
| console.log(`nonce`) | |||
There was a problem hiding this comment.
Cleanup console.logs here. Or if you want a real log for the checker, then move it into the check implementation?
Comment on lines
+1540
to
+1546
| let rpcServerWithApiKey: string | ||
| try { | ||
| rpcServerWithApiKey = this.addRpcApiKey(rpcServer) | ||
| } catch (e) { | ||
| // addRpcApiKey can throw if there's a missing apikey. skip this rpcServer | ||
| return | ||
| } |
There was a problem hiding this comment.
Hmm, if all RPC servers fail on this adding of key step, then this means balance checking via RPC is not possible. There are other methods to get balances which wont be used because of the condition on line 1787. This can surface itself as a bug as well, so this only partly fixes the problem.
paullinator
force-pushed
the
paul/fixEvmSync
branch
from
ccd3cbf to
d63585c
Compare
samholmes
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none