Merge pull request #668 from EdgeApp/paul/fixEvmSync

Fix failed sync of evm wallets
EdgeApp · Nov 13, 2023 · deecf06 · deecf06
2 parents b991147 + d63585c
commit deecf06
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- fixed: EVM balance sync failure if missing API key for one node type
+
 ## 2.11.1 (2023-11-10)
 
 - fixed: Use transaction type 0 (legacy transactions) currencies which do no support EIP-1559

diff --git a/src/ethereum/EthereumNetwork.ts b/src/ethereum/EthereumNetwork.ts
@@ -1537,7 +1537,13 @@ export class EthereumNetwork {
 
     let funcs: Array<() => Promise<any>> = []
     rpcServers.forEach(rpcServer => {
-      const rpcServerWithApiKey = this.addRpcApiKey(rpcServer)
+      let rpcServerWithApiKey: string
+      try {
+        rpcServerWithApiKey = this.addRpcApiKey(rpcServer)
+      } catch (e) {
+        // addRpcApiKey can throw if there's a missing apikey. skip this rpcServer
+        return
+      }
       const ethProvider = new ethers.providers.JsonRpcProvider(
         rpcServerWithApiKey,
         chainParams.chainId