-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create scheme for cam_thermo_water_update using dependency method #177
Labels
enhancement
New feature or request
Comments
This was referenced Dec 12, 2024
jimmielin
added a commit
that referenced
this issue
Feb 14, 2025
…rmo_water_update) (#178) Originator(s): @jimmielin Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number): Closes #177, implementing thermo_water_update scheme to call cam_thermo_water_update. Describe any changes made to the namelist: N/A List all files eliminated and why: N/A List all files added and what they do: Implement thermo_water_update scheme A schemes/thermo_water_update/thermo_water_update.F90 A schemes/thermo_water_update/thermo_water_update.meta List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) Include thermo_water_update scheme in CAM7 suite and simple physics suites M suites/suite_cam7.xml M suites/suite_kessler.xml M suites/suite_tj2016.xml List any test failures: Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? Yes --------- Co-authored-by: Jesse Nusbaumer <[email protected]>
Fixed in #178 |
mattldawson
pushed a commit
that referenced
this issue
Feb 20, 2025
…rmo_water_update) (#178) Originator(s): @jimmielin Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number): Closes #177, implementing thermo_water_update scheme to call cam_thermo_water_update. Describe any changes made to the namelist: N/A List all files eliminated and why: N/A List all files added and what they do: Implement thermo_water_update scheme A schemes/thermo_water_update/thermo_water_update.F90 A schemes/thermo_water_update/thermo_water_update.meta List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) Include thermo_water_update scheme in CAM7 suite and simple physics suites M suites/suite_cam7.xml M suites/suite_kessler.xml M suites/suite_tj2016.xml List any test failures: Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? Yes --------- Co-authored-by: Jesse Nusbaumer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cam_thermo_water_update
has to run a second time (the first time is indp_coupling
) beforedycore_energy_consistency_adjust
scheme runs, to provide updated generalized cp:For both CAM4/5/6 and CAM7:
cam_thermo_water_update
is currently insrc/data/cam_thermo.F90
. It callswater_composition_update
insrc/data/air_composition.F90
, which depends onget_cp_1hd
(which depends onget_cp_dry_1hd
) inair_composition
;get_R_1hd
(which depends onget_R_dry_1hd
) inair_composition
;air_composition
, i.e.,thermodynamic_active_species_num
,thermodynamic_active_species_idx
,dry_air_species_num
,thermodynamic_active_species_cp
,thermodynamic_active_species_R
Because
air_composition
properties and subroutines are also dependent on the dycore, it may not be feasible to CCPPize the entirecam_thermo_water_update
and its related subroutines.A dependent scheme can be made that depends on
src/data/cam_thermo.F90
and calls the underlyingcam_thermo_water_update
with theto_dry_factor
(note: the call from the dycore does not include this factor.) which would allow the CAM4/5/6/7 suites to run properly until the CAM thermo infrastructure can be completely CCPPized (if in the future)The text was updated successfully, but these errors were encountered: