Enable new crop calendars for clm60 compsets

[samsrabin]

Description of changes

Enables cropcals_rx_adapt by default for clm60.

Specific notes

Contributors other than yourself, if any: @slevis-lmwg

Are answers expected to change (and if so in what way)? Yes. Relative to ctsm5.2.015:

• Any clm6 compset with crops enabled, except maybe very short runs where no planting has time to occur with either crop calendar setup.
• Any test that uses or inherits the crop testmod will have answers change due to more frequent writing of the h2 file. Note that this only affects tests.
• Most, if not all, tests will have namelist differences.

Any User Interface Changes (namelist or namelist defaults changes)?

• Add cropcals_rx, default false.
• Add cropcals_rx_adapt, default true. This is what changes default behavior.
• Rename stream_year_first_cropcal to stream_year_first_cropcal_swindows
• Rename stream_year_last_cropcal to stream_year_last_cropcal_swindows
• Rename model_year_align_cropcal to model_year_align_cropcal_swindows
• Add stream_year_first_cropcal_cultivar_gdds
• Add stream_year_last_cropcal_cultivar_gdds
• Add model_year_align_cropcal_cultivar_gdds
• Add stream_fldFileName_gdd20_baseline
• Add stream_gdd20_seasons (experimental)
• Add flush_gdd20 (experimental)
• Add stream_fldFileName_gdd20_season_start (experimental)
• Add stream_fldFileName_gdd20_season_end (experimental)
• Add allow_invalid_gdd20_season_inputs

Does this create a need to change or add documentation? Did you do so?

• Yes
• No

Testing performed

aux_clm compared to ctsm5.2.015:

• Derecho ❌ (baseline named ctsm5.2.016_cropcals) at 542f708: 10 run failures. Resubmitted those 10 after changes in 126ce29..2156c72 (/glade/derecho/scratch/samrabin/tests_0726-084119de/)...
• Izumi ✅ (baseline named ctsm5.2.016) at 542f708

Rerunning both after bug fixes (b1aed3f), comparing to baselines generated above, skipping generate (all should PASS except expected failures):

• Derecho ⏳: /glade/derecho/scratch/samrabin/tests_0726-091635de/
• Izumi ✅: /scratch/cluster/samrabin/tests_0726-091602iz/, /scratch/cluster/samrabin/tests_0726-122439iz

I used the wrong --compare for that latest Derecho test suite, so it will have to be checked manually:

cd ~samrabin/ctsm_scale-mat-reqs-pr4-makedefault

cime/CIME/Tools/compare_test_results \
-b ctsm5.2.016_cropcals \
--baseline-root /glade/campaign/cgd/tss/ctsm_baselines \
-r /glade/derecho/scratch/samrabin/tests_0726-091635de

Python tests (unit, system, black, pylint)

✅ pass as of 2156c72.

Namelist build tests

🆗. 4 fail; see #2666.

[slevis-lmwg]

@samsrabin I have reviewed this PR and see no problems with it. If I understand correctly, this work sets the stage for bringing in #2593, which we discussed at length a few days ago, right?

Thank you for all this work!

[samsrabin]

If I understand correctly, this work sets the stage for bringing in #2593, which we discussed at length a few days ago, right?

Yes, but not just that! Here's the full list of PRs that have been merged into this development branch before this one:

• Allow prescribed gddmaturity to vary based on recent climate (initial work, v2) #2560
• Allow "manual" resets of all accumulator types #2585
• Optionally base GDD20 on per-gridcell windows, not per-hemisphere #2593
• Merge ctsm5.2.015 into scale-maturity-reqs #2661

[ekluzek]

Tests on Derecho are still going, but merging this to the branch now. We'll work out the tests for the PR to master.