Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ctsm5.2.015 into scale-maturity-reqs #2661

Merged

Conversation

samsrabin
Copy link
Collaborator

@samsrabin samsrabin commented Jul 25, 2024

Description of changes

Just merges in the latest CTSM master code.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed: None

Are answers expected to change (and if so in what way)?

  • Any test that uses or inherits the crop testmod will have answers change due to more frequent writing of the h2 file. Note that this only affects tests.
  • Most, if not all, tests will have namelist differences.

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any:

  • aux_clm on Izumi: ✅ as expected
  • aux_clm on Derecho: 🛑 halted: /glade/derecho/scratch/samrabin/tests_0725-090556de. Was queued for way too long, and in the meantime, these tests have been superseded by the testing for Enable new crop calendars for clm60 compsets #2664.

jedwards4b and others added 30 commits May 27, 2024 17:40
Update Externals.cfg to cesm2_3_beta17, remove mct, retire /test/tools
Update externals to cesm2_3_beta17, remove mct, retire /test/tools

Changes unrelated to the tag's title:
Update externals to cesm2_3_beta17, remove mct, retire /test/tools

Changes unrelated to the tag's title:
… into ctsm5.2.007/candidate

slevis resolved conflicts:
README
Fix `PVT` system test and avoid getting `fluh_timeseries` when `use_fates_potentialveg = .true.`
slevis-lmwg and others added 23 commits July 16, 2024 12:12
Relax tolerance for truncating small snocan values in CanopyFluxes

See the PR ESCOMP#2457 for details.
Relax tolerance for truncating small snocan values in CanopyFluxes

See the PR ESCOMP#2457 for details.
FATES land use v2 API update (CTSM-side)
slevis resolved conflicts:
bld/unit_testers/build-namelist_test.pl
use_matrixcn and use_soil_matrixcn are coming in as default .false.
ERS_D.f19_g17.I1850Clm50BgcCrop.izumi_nag.clm-ciso_monthly_matrixcn_spinup
failed during the build because a namelist variable needed renaming
Update submodule tags to pass runoff from CISM to ROF as per issue ESCOMP#2590
Update submodule tags to pass runoff from cism to rof

- Update MOSART, CMEPS, and CISM so CISM runoff goes to ROF rather than CTSM
- Update RTM with fix needed for Paleo LGM work

Contributors:
@mvertens, @jedwards4b, @billsacks, @Katetc, @ekluzek, @slevis-lmwg

 Fixes ESCOMP#2590 Update CMEPS/MOSART/CISM/RTM tags
 Fixes ESCOMP/RTM#50 Likely wrong RTM river flux to MOM6 within cesm2_3_beta17

 Differences in namelist 'mosart_inparm':
  missing variable: 'do_rtmflood'
  missing variable: 'finidat_rtm'
  missing variable: 'frivinp_rtm'
  missing variable: 'rtmhist_fexcl1'
  missing variable: 'rtmhist_fexcl2'
  missing variable: 'rtmhist_fexcl3'
  missing variable: 'rtmhist_fincl1'
  missing variable: 'rtmhist_fincl2'
  missing variable: 'rtmhist_fincl3'
  missing variable: 'rtmhist_mfilt'
  missing variable: 'rtmhist_ndens'
  missing variable: 'rtmhist_nhtfrq'
  found extra variable: 'budget_frq'
  found extra variable: 'fexcl1'
  found extra variable: 'fexcl2'
  found extra variable: 'fexcl3'
  found extra variable: 'fincl1'
  found extra variable: 'fincl2'
  found extra variable: 'fincl3'
  found extra variable: 'finidat'
  found extra variable: 'frivinp'
  found extra variable: 'mfilt'
  found extra variable: 'mosart_euler_calc'
  found extra variable: 'mosart_tracers'
  found extra variable: 'ndens'
  found extra variable: 'nhtfrq'
  found extra variable: 'use_halo_option'

Changes answers
- what code configurations: mosart and rtm
- what platforms/compilers: all
- nature of change: mosart roundoff; rtm larger than roundoff due to bug fix; the latter also affects bgc variables

 We are ignoring strange diffs from baseline in two tests in variable
 FATES_TRANSITION_MATRIX_LULU as explained in issue ESCOMP#2656.
@samsrabin samsrabin self-assigned this Jul 25, 2024
@samsrabin samsrabin marked this pull request as ready for review July 26, 2024 14:02
@samsrabin samsrabin requested a review from slevis-lmwg July 26, 2024 14:03
@samsrabin
Copy link
Collaborator Author

@slevis-lmwg This is ready for review. You shouldn't really need to look over anything; it's just a pure merge of ctsm5.2.015 with no conflicts.

Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsrabin based on your comment that this is simply a merge with 015 without conflicts, I am approving without looking more closely.

@samsrabin samsrabin merged commit 3631dc9 into ESCOMP:scale-maturity-reqs Jul 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants