cam6_3_089: TEM diagnostics calculated on the physics grid #677

fvitt · 2022-10-20T15:52:56Z

Transformed Eulerian Mean (TEM) diagnostics calculated on the physics grid, independent of dynamical core.

closes #653
closes #652

new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_physgrid_tem/shell_commands new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_physgrid_tem/user_nl_cam new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_physgrid_tem/user_nl_clm new file: src/physics/cam/phys_grid_ctem.F90 new file: src/utils/zonal_mean_mod.F90 modified: bld/namelist_files/namelist_definition.xml modified: src/control/cam_comp.F90 modified: src/control/runtime_opts.F90 modified: src/physics/cam/physpkg.F90

modified: src/physics/cam/phys_grid_ctem.F90

modified: src/physics/cam/phys_grid_ctem.F90 modified: src/physics/cam/physpkg.F90

modified: src/physics/cam/phys_grid_ctem.F90

nusbaume · 2022-10-20T16:54:37Z

@fvitt just double checking if this is purposefully a draft PR?

fvitt · 2022-10-20T17:02:44Z

@fvitt just double checking if this is purposefully a draft PR?

Yes, this is meant to be a draft PR for now.

fvitt · 2022-10-21T17:25:56Z

@dan800 @nadavis-ncar :
I want to bring this PR to your attention. Please review when you get a chance.

modified: src/utils/zonal_mean_mod.F90

modified: bld/namelist_files/namelist_defaults_cam.xml new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_physgrid_tem_1deg/shell_commands new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_physgrid_tem_1deg/user_nl_cam new file: cime_config/testdefs/testmods_dirs/cam/outfrq9s_physgrid_tem_1deg/user_nl_clm

dan800 · 2022-11-04T12:09:13Z

@fvitt Can you explain the rationale behind the "zm3d" namelist variables, e.g.,

call addfld ('VTHzm3d',(/'ilev' /), 'A','MK/S', 'Meridional Heat Flux: 3D zon. mean', gridname='physgrid' )

At least to me it seems contradictory/confusing.

fvitt · 2022-11-04T14:26:59Z

@dan800
The "zm3d" history fields are 3-dimensional zonal mean fields. They were added before the zonal average history output was working (the "zaphys" fields). I left them for now to verify that the zonal average output was working as expected. Maybe the "zm3d" should be removed now.

fvitt · 2022-11-04T14:34:22Z

@dan800 , @nadavis-ncar :

Sample runs can be found under:
/glade/scratch/fvitt/FWsc2000climo_f09_TEM_test04
/glade/scratch/fvitt/FWsc2000climo_ne30pg3_TEM_test04

Source code on cheyenne is under :
/glade/work/fvitt/camdev/physgrid_tem_diags02

new file: cime_config/testdefs/testmods_dirs/cam/outfrq1d_physgrid_tem_mpasa120_wcmsc/shell_commands new file: cime_config/testdefs/testmods_dirs/cam/outfrq1d_physgrid_tem_mpasa120_wcmsc/user_nl_cam new file: cime_config/testdefs/testmods_dirs/cam/outfrq1d_physgrid_tem_mpasa120_wcmsc/user_nl_clm modified: bld/namelist_files/use_cases/waccm_sc_2000_cam6.xml

modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_physgrid_tem/user_nl_cam modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_physgrid_tem_1deg/user_nl_cam modified: src/physics/cam/phys_grid_ctem.F90

peverwhee · 2022-11-09T16:45:30Z

@fvitt @cacraigucar it looks like this code is dependent on #629 - is that correct? If so, I will give that code an initial review first.

fvitt · 2022-11-09T17:01:41Z

@peverwhee This is PR can be reviewed independent from #629. This PR includes the utility module zonal_mean_mod.F90 file, which is also included in #629.

peverwhee · 2022-11-09T17:04:26Z

@fvitt ahh gotcha. Thanks.

peverwhee

a few (hopefully) small requests

src/physics/cam/phys_grid_ctem.F90

src/utils/zonal_mean_mod.F90

…iewer modified: bld/namelist_files/namelist_definition.xml modified: cime_config/testdefs/testmods_dirs/cam/outfrq1d_physgrid_tem_mpasa120_wcmsc/user_nl_cam modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_physgrid_tem/user_nl_cam modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_physgrid_tem_1deg/user_nl_cam modified: src/physics/cam/phys_grid_ctem.F90

modified: src/utils/zonal_mean_mod.F90

modified: src/physics/cam/phys_grid_ctem.F90 modified: src/physics/cam/physpkg.F90 modified: src/utils/zonal_mean_mod.F90

modified: src/utils/zonal_mean_mod.F90

peverwhee

Looks good - I added a comment explaining my question about orthogonality (though it should've been orthonormality) but will move this to full review

src/utils/zonal_mean_mod.F90

cime_config/testdefs/testmods_dirs/cam/outfrq1d_physgrid_tem_mpasa120_wcmsc/user_nl_cam

dan800 · 2022-12-21T18:53:39Z

src/physics/cam/phys_grid_ctem.F90

+       ! vertical velocity
+       w(:ncol,:,lchnk)  = -sheight(:ncol,:) *  phys_state(lchnk)%omega(:ncol,:) / phys_state(lchnk)%pmid(:ncol,:)
+
+      ! interpolate to layer interfaces


This is unnecessary - no need to interpolate output to ilev. Prefer output on lev anyway.

The vertical interpolations have been removed. The calculations and output are now at the model layer mid-points.

modified: src/physics/cam/phys_grid_ctem.F90

dan800 · 2022-12-23T19:32:59Z

@fvitt Great. Can you run out the model for a few months with the new output format (on lev), so I can test my post-processing code.

…

On Wed, Dec 21, 2022 at 3:33 PM Francis Vitt ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/physics/cam/phys_grid_ctem.F90 <#677 (comment)>: > + uvp(:,:,:) = 0._r8 + + do lchnk = begchunk,endchunk + + ncol = phys_state(lchnk)%ncol + + ! scale height + sheight(:ncol,:) = phys_state(lchnk)%t(:ncol,:) * rgas / ( mbarv(:ncol,:,lchnk) * grav ) ! meters + + ! potential temperature + theta(:ncol,:,lchnk) = phys_state(lchnk)%t(:ncol,:) * phys_state(lchnk)%exner(:ncol,:) + + ! vertical velocity + w(:ncol,:,lchnk) = -sheight(:ncol,:) * phys_state(lchnk)%omega(:ncol,:) / phys_state(lchnk)%pmid(:ncol,:) + + ! interpolate to layer interfaces The vertical interpolations have been removed. The calculations and output are now at the model layer mid-points. — Reply to this email directly, view it on GitHub <#677 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJBT7ICWDAT3R42E2RS2RVLWOOAT5ANCNFSM6AAAAAARKJRHD4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Climate and Global Dynamics Laboratory & The High Altitude Observatory National Center for Atmospheric Research, Boulder, Colorado 80307-3000 phone: +1 303 497-1160 fax: +1 303 497-1400 email: ***@***.***

fvitt · 2022-12-23T20:06:08Z

@fvitt Great. Can you run out the model for a few months with the new output format (on lev), so I can test my post-processing code.

@dan800 , These cases are run for 2 months. Do I need to run longer?

/glade/scratch/fvitt/FWsc2000climo_f09_TEM_test06
/glade/scratch/fvitt/FWsc2000climo_ne30pg3_TEM_test06

Find history under
/glade/scratch/fvitt/archive/FWsc2000climo_f09_TEM_test06
/glade/scratch/fvitt/archive/FWsc2000climo_ne30pg3_TEM_test06

nusbaume

Definitely a lot of great work! I'll admit I have a fair amount of comments, but hopefully all of them are relatively simple to implement. Of course let me know if you have any questions or concerns with my suggestions.

bld/namelist_files/namelist_defaults_cam.xml

bld/namelist_files/use_cases/waccm_sc_2000_cam6.xml

cime_config/testdefs/testmods_dirs/cam/outfrq1d_physgrid_tem_mpasa120_wcmsc/user_nl_cam

src/physics/cam/phys_grid_ctem.F90

src/utils/zonal_mean_mod.F90

modified: src/physics/cam/phys_grid_ctem.F90

modified: src/physics/cam/phys_grid_ctem.F90 modified: src/utils/zonal_mean_mod.F90

modified: cime_config/testdefs/testlist_cam.xml modified: cime_config/testdefs/testmods_dirs/cam/outfrq3s_physgrid_tem/user_nl_cam modified: cime_config/testdefs/testmods_dirs/cam/outfrq3s_physgrid_tem/user_nl_clm renamed: cime_config/testdefs/testmods_dirs/cam/outfrq9s_physgrid_tem/shell_commands -> cime_config/testdefs/testmods_dirs/cam/outfrq3s_physgrid_tem/shell_commands renamed: cime_config/testdefs/testmods_dirs/cam/outfrq9s_physgrid_tem/user_nl_cam -> cime_config/testdefs/testmods_dirs/cam/outfrq3s_physgrid_tem/user_nl_cam renamed: cime_config/testdefs/testmods_dirs/cam/outfrq9s_physgrid_tem/user_nl_clm -> cime_config/testdefs/testmods_dirs/cam/outfrq3s_physgrid_tem/user_nl_clm

cime_config/testdefs/testlist_cam.xml

src/physics/cam/phys_grid_ctem.F90

src/utils/zonal_mean_mod.F90

modified: cime_config/testdefs/testlist_cam.xml modified: src/physics/cam/phys_grid_ctem.F90

nusbaume

Looks good to me now! I just have a few last one-line change requests, but hopefully nothing that seriously holds up this PR.

src/utils/zonal_mean_mod.F90

modified: src/utils/zonal_mean_mod.F90

…em_diags

fvitt added 4 commits October 17, 2022 16:33

add conditionals for doing the TEM daigs

f059e4e

modified: src/physics/cam/phys_grid_ctem.F90

calculate scale height; add comments

7683d54

modified: src/physics/cam/phys_grid_ctem.F90 modified: src/physics/cam/physpkg.F90

fix bug in do_tem_diags setting

706ede3

modified: src/physics/cam/phys_grid_ctem.F90

fvitt added enhancement New feature or request BFB bit for bit tag labels Oct 20, 2022

fvitt self-assigned this Oct 20, 2022

fvitt added 2 commits November 1, 2022 08:51

declare lower bound begchunk in assumed shape array args

e9caadc

modified: src/utils/zonal_mean_mod.F90

fvitt marked this pull request as ready for review November 8, 2022 16:41

fvitt requested review from dan800 and peverwhee November 8, 2022 16:41

remove debugging diagnostics (*zm3d history fields)

b2f6a14

modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_physgrid_tem/user_nl_cam modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_physgrid_tem_1deg/user_nl_cam modified: src/physics/cam/phys_grid_ctem.F90

peverwhee requested changes Nov 9, 2022

View reviewed changes

fvitt added 4 commits November 9, 2022 16:45

misc changes requested by code reviewer (round 2)

5bbcc0e

modified: src/utils/zonal_mean_mod.F90

implement final routines; mics changes

f45f732

modified: src/physics/cam/phys_grid_ctem.F90 modified: src/physics/cam/physpkg.F90 modified: src/utils/zonal_mean_mod.F90

tweaks to some of the comments

5ef0f8b

modified: src/utils/zonal_mean_mod.F90

fvitt requested a review from peverwhee November 10, 2022 16:11

peverwhee approved these changes Nov 10, 2022

View reviewed changes

src/utils/zonal_mean_mod.F90 Show resolved Hide resolved

cacraigucar reviewed Dec 2, 2022

View reviewed changes

cime_config/testdefs/testmods_dirs/cam/outfrq1d_physgrid_tem_mpasa120_wcmsc/user_nl_cam Show resolved Hide resolved

cacraigucar changed the title ~~TEM diagnostics calculated on the physics grid~~ part of cam6_3_086: TEM diagnostics calculated on the physics grid Dec 9, 2022

cacraigucar changed the title ~~part of cam6_3_086: TEM diagnostics calculated on the physics grid~~ TEM diagnostics calculated on the physics grid Dec 9, 2022

dan800 suggested changes Dec 21, 2022

View reviewed changes

Remove vertical interpolation onto layer interfaces

3d9d37d

modified: src/physics/cam/phys_grid_ctem.F90

nusbaume requested changes Dec 29, 2022

View reviewed changes

fvitt added 4 commits January 3, 2023 10:42

correction to array ncol extent

b39baa3

modified: src/physics/cam/phys_grid_ctem.F90

the majority of Jesse's change requests

d29da6e

modified: src/physics/cam/phys_grid_ctem.F90 modified: src/utils/zonal_mean_mod.F90

more misc changes suggested by Jesse

a9a24d7

modified: src/physics/cam/phys_grid_ctem.F90 modified: src/utils/zonal_mean_mod.F90

fvitt requested review from cacraigucar and nusbaume January 4, 2023 21:30

cacraigucar reviewed Jan 4, 2023

View reviewed changes

cime_config/testdefs/testlist_cam.xml Outdated Show resolved Hide resolved

src/physics/cam/phys_grid_ctem.F90 Outdated Show resolved Hide resolved

nusbaume reviewed Jan 6, 2023

View reviewed changes

src/physics/cam/phys_grid_ctem.F90 Outdated Show resolved Hide resolved

src/physics/cam/phys_grid_ctem.F90 Outdated Show resolved Hide resolved

nusbaume reviewed Jan 6, 2023

View reviewed changes

src/utils/zonal_mean_mod.F90 Outdated Show resolved Hide resolved

src/utils/zonal_mean_mod.F90 Outdated Show resolved Hide resolved

src/utils/zonal_mean_mod.F90 Outdated Show resolved Hide resolved

update to history fields; move mpas tem test to prealpha

8927292

modified: cime_config/testdefs/testlist_cam.xml modified: src/physics/cam/phys_grid_ctem.F90

cacraigucar changed the title ~~TEM diagnostics calculated on the physics grid~~ cam6_3_089?: TEM diagnostics calculated on the physics grid Jan 6, 2023

nusbaume mentioned this pull request Jan 9, 2023

Replace "Invert_Matrix" subroutine in "zonal_mean_mod.F90" with LAPACK version #736

Closed

nusbaume approved these changes Jan 9, 2023

View reviewed changes

fvitt added 2 commits January 9, 2023 13:33

fix 2pi issue; misc clean up

b2901b0

modified: src/utils/zonal_mean_mod.F90

initialize dcor in sh_create_gaus_grid

1457f8e

modified: src/utils/zonal_mean_mod.F90

cacraigucar approved these changes Jan 9, 2023

View reviewed changes

Merge remote-tracking branch 'ESCOMP/cam_development' into physgrid_t…

8fc80b8

…em_diags

jtruesdal removed their request for review January 9, 2023 22:30

cacraigucar changed the title ~~cam6_3_089?: TEM diagnostics calculated on the physics grid~~ cam6_3_089: TEM diagnostics calculated on the physics grid Jan 9, 2023

fvitt added 2 commits January 10, 2023 09:56

ChangeLog draft

903c2df

ChangeLog updates

479bf60

fvitt merged commit ad46750 into ESCOMP:cam_development Jan 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cam6_3_089: TEM diagnostics calculated on the physics grid #677

cam6_3_089: TEM diagnostics calculated on the physics grid #677

fvitt commented Oct 20, 2022

nusbaume commented Oct 20, 2022

fvitt commented Oct 20, 2022

fvitt commented Oct 21, 2022

dan800 commented Nov 4, 2022

fvitt commented Nov 4, 2022

fvitt commented Nov 4, 2022

peverwhee commented Nov 9, 2022

fvitt commented Nov 9, 2022

peverwhee commented Nov 9, 2022

peverwhee left a comment

peverwhee left a comment

dan800 Dec 21, 2022

fvitt Dec 21, 2022

dan800 commented Dec 23, 2022 via email

fvitt commented Dec 23, 2022

nusbaume left a comment

nusbaume left a comment

cam6_3_089: TEM diagnostics calculated on the physics grid #677

cam6_3_089: TEM diagnostics calculated on the physics grid #677

Conversation

fvitt commented Oct 20, 2022

nusbaume commented Oct 20, 2022

fvitt commented Oct 20, 2022

fvitt commented Oct 21, 2022

dan800 commented Nov 4, 2022

fvitt commented Nov 4, 2022

fvitt commented Nov 4, 2022

peverwhee commented Nov 9, 2022

fvitt commented Nov 9, 2022

peverwhee commented Nov 9, 2022

peverwhee left a comment

Choose a reason for hiding this comment

peverwhee left a comment

Choose a reason for hiding this comment

dan800 Dec 21, 2022

Choose a reason for hiding this comment

fvitt Dec 21, 2022

Choose a reason for hiding this comment

dan800 commented Dec 23, 2022 via email

fvitt commented Dec 23, 2022

nusbaume left a comment

Choose a reason for hiding this comment

nusbaume left a comment

Choose a reason for hiding this comment