Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "Invert_Matrix" subroutine in "zonal_mean_mod.F90" with LAPACK version #736

Closed
nusbaume opened this issue Jan 9, 2023 · 1 comment
Closed

Replace "Invert_Matrix" subroutine in "zonal_mean_mod.F90" with LAPACK version #736

nusbaume opened this issue Jan 9, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@nusbaume
Copy link
Collaborator

nusbaume commented Jan 9, 2023 •
edited by peverwhee
Loading

Issue Type

Code Clean-up

Issue Description

PR #677 will bring in a new "zonal_mean_mod.F90" that has its own matrix inversion subroutine (Invert_Matrix). However, given that CAM already uses LAPACK, and that LAPACK has optimized routines to do matrix inversion, it would make sense to replace this Invert_Matrix subroutine with one from LAPACK.

Will this change answers?

I Don't Know

Will you be implementing this yourself?

Any CAM SE can do this

closes #745
@nusbaume nusbaume added the enhancement New feature or request label Jan 9, 2023
@nusbaume nusbaume mentioned this issue Jan 9, 2023
Merged
@nusbaume nusbaume mentioned this issue Jan 26, 2023
Closed
@peverwhee
Copy link
Collaborator

The PR for this issue can close #745 as well

@brian-eaton brian-eaton mentioned this issue Apr 13, 2023
Merged
@github-project-automation github-project-automation bot moved this from To Do to Done in CAM Development Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
CAM Development
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peverwhee @nusbaume